zishuo/webrtc
1
0
Fork 0
mirror of https://github.com/pion/webrtc.git synced 2025-12-24 11:51:03 +08:00
Code Issues Packages Projects Releases Wiki Activity

Undo OGG API deprecation

Browse Source 
Add a warning that it's a single track / header instead.
And plan the deprecation for the next major release.
This commit is contained in:
Joe Turki
2025-12-20 21:02:13 +02:00
parent d8828d6df0
commit 39dee988fe
1 changed files with 5 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
pkg/media/oggreader/oggreader.go
View File

@@ -123,7 +123,11 @@ type Option func(*OggReader) error
// NewWith returns a new Ogg reader and Ogg header // NewWith returns a new Ogg reader and Ogg header
// with an io.Reader input. // with an io.Reader input.
// Deprecated: Use NewWithOptions instead. //
// Warning: NewWith only parses the first OpusHead (a single logical bitstream/track)
// and returns a single OggHeader. If you need to handle Ogg containers with multiple
// Opus headers/tracks, use NewWithOptions and scan pages (e.g. via ParseNextPage)
// to find and parse each OpusHead.
func NewWith(in io.Reader) (*OggReader, *OggHeader, error) { func NewWith(in io.Reader) (*OggReader, *OggHeader, error) {
return newWith(in /* doChecksum */, true) return newWith(in /* doChecksum */, true)
} }