From 39dee988feca5f297deb3572e92f37074ebe8246 Mon Sep 17 00:00:00 2001 From: Joe Turki Date: Sat, 20 Dec 2025 21:02:13 +0200 Subject: [PATCH] Undo OGG API deprecation Add a warning that it's a single track / header instead. And plan the deprecation for the next major release. --- pkg/media/oggreader/oggreader.go | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/pkg/media/oggreader/oggreader.go b/pkg/media/oggreader/oggreader.go index 94bd6e77..e4c773ba 100644 --- a/pkg/media/oggreader/oggreader.go +++ b/pkg/media/oggreader/oggreader.go @@ -123,7 +123,11 @@ type Option func(*OggReader) error // NewWith returns a new Ogg reader and Ogg header // with an io.Reader input. -// Deprecated: Use NewWithOptions instead. +// +// Warning: NewWith only parses the first OpusHead (a single logical bitstream/track) +// and returns a single OggHeader. If you need to handle Ogg containers with multiple +// Opus headers/tracks, use NewWithOptions and scan pages (e.g. via ParseNextPage) +// to find and parse each OpusHead. func NewWith(in io.Reader) (*OggReader, *OggHeader, error) { return newWith(in /* doChecksum */, true) }