zishuo/webrtc
1
0
Fork 0
mirror of https://github.com/pion/webrtc.git synced 2025-09-27 03:25:58 +08:00
Code Issues Packages Projects Releases Wiki Activity

Fix TestExtensionIdCollision

Browse Source 
This test previously assumed deterministic (i.e. ordered)
behaviour for getRTPParametersByKind which is not necessary, and
is no longer true following PR #2236 due to use of range. The
result was that occasionally this test would fail incorrectly
(thanks, golang-ci). This PR fixes the test.
This commit is contained in:
Adrian Cable
2022-05-23 18:05:51 -07:00
committed by Adrian Cable
parent 89c05b714f
commit 14c032ce72
1 changed files with 22 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

28
mediaengine_test.go
View File

@@ -525,10 +525,26 @@ a=rtpmap:111 opus/48000/2
extensions := params.HeaderExtensions
assert.Equal(t, 2, len(extensions))
assert.Equal(t, sdp.SDESMidURI, extensions[0].URI)
assert.Equal(t, 2, extensions[0].ID)
assert.Equal(t, "urn:3gpp:video-orientation", extensions[1].URI)
assert.NotEqual(t, 1, extensions[1].ID)
assert.NotEqual(t, 2, extensions[1].ID)
assert.NotEqual(t, 5, extensions[1].ID)
midIndex := -1;
if extensions[0].URI == sdp.SDESMidURI {
midIndex = 0
} else if extensions[1].URI == sdp.SDESMidURI {
midIndex = 1
}
voIndex := -1;
if extensions[0].URI == "urn:3gpp:video-orientation" {
voIndex = 0
} else if extensions[1].URI == "urn:3gpp:video-orientation" {
voIndex = 1
}
assert.NotEqual(t, midIndex, -1)
assert.NotEqual(t, voIndex, -1)
assert.Equal(t, 2, extensions[midIndex].ID)
assert.NotEqual(t, 1, extensions[voIndex].ID)
assert.NotEqual(t, 2, extensions[voIndex].ID)
assert.NotEqual(t, 5, extensions[voIndex].ID)
}