From 14c032ce722d8273c5d95e355e62b513e4381567 Mon Sep 17 00:00:00 2001
From: Adrian Cable <adrian.cable@gmail.com>
Date: Mon, 23 May 2022 18:05:51 -0700
Subject: [PATCH] Fix TestExtensionIdCollision

This test previously assumed deterministic (i.e. ordered)
behaviour for getRTPParametersByKind which is not necessary, and
is no longer true following PR #2236 due to use of range. The
result was that occasionally this test would fail incorrectly
(thanks, golang-ci). This PR fixes the test.
---
 mediaengine_test.go | 28 ++++++++++++++++++++++------
 1 file changed, 22 insertions(+), 6 deletions(-)

diff --git a/mediaengine_test.go b/mediaengine_test.go
index 5761f98e..17b8839c 100644
--- a/mediaengine_test.go
+++ b/mediaengine_test.go
@@ -525,10 +525,26 @@ a=rtpmap:111 opus/48000/2
 	extensions := params.HeaderExtensions
 
 	assert.Equal(t, 2, len(extensions))
-	assert.Equal(t, sdp.SDESMidURI, extensions[0].URI)
-	assert.Equal(t, 2, extensions[0].ID)
-	assert.Equal(t, "urn:3gpp:video-orientation", extensions[1].URI)
-	assert.NotEqual(t, 1, extensions[1].ID)
-	assert.NotEqual(t, 2, extensions[1].ID)
-	assert.NotEqual(t, 5, extensions[1].ID)
+
+	midIndex := -1;
+	if extensions[0].URI == sdp.SDESMidURI {
+		midIndex = 0
+	} else if extensions[1].URI == sdp.SDESMidURI {
+		midIndex = 1
+	}
+
+	voIndex := -1;
+	if extensions[0].URI == "urn:3gpp:video-orientation" {
+		voIndex = 0
+	} else if extensions[1].URI == "urn:3gpp:video-orientation" {
+		voIndex = 1
+	}
+
+	assert.NotEqual(t, midIndex, -1)
+	assert.NotEqual(t, voIndex, -1)
+
+	assert.Equal(t, 2, extensions[midIndex].ID)
+	assert.NotEqual(t, 1, extensions[voIndex].ID)
+	assert.NotEqual(t, 2, extensions[voIndex].ID)
+	assert.NotEqual(t, 5, extensions[voIndex].ID)
 }