chore: codacy

helper/Dockerfile

@@ -3,7 +3,7 @@ FROM golang:1.15.5 AS builder
 WORKDIR /
 
 RUN apt-get update
-RUN apt-get install unzip
+RUN apt-get install -y --no-install-recommends unzip=6.0-23+deb10u1
 RUN curl -sL -o protoc.zip https://github.com/protocolbuffers/protobuf/releases/download/v3.14.0/protoc-3.14.0-linux-x86_64.zip
 RUN unzip protoc.zip -d proto
 RUN curl -sL -o jq https://github.com/stedolan/jq/releases/download/jq-1.6/jq-linux64

helper/README.md

@@ -1,18 +1,18 @@
-# About
+# Onepanel Core Helper
 
 Helper provides the files to build a Docker image to assist 
 with code generation for the onepanel-core project.
 
 In particular, you can use the docker image to generate all of the gRPC related files, as well as create migrations.
 
-# Build
+## Build
 
 To build, it should be sufficient to run 
 ```bash
 docker build -t onepanel/helper:v1.0.0 .
 ```
 
-## Updating
+### Updating
 
 Create a new directory somewhere outside of this project.
 

helper/tools.go

@@ -1,6 +1,6 @@
 // +build tools
 
-package core_helper
+package corehelper
 
 import (
 	_ "github.com/grpc-ecosystem/grpc-gateway/v2/protoc-gen-grpc-gateway"

server/cron_workflow_server.go

@@ -11,10 +11,12 @@ import (
 	"github.com/onepanelio/core/server/converter"
 )
 
+// CronWorkflowServer is an implementation of the grpc CronWorkflowServer
 type CronWorkflowServer struct {
 	api.UnimplementedCronWorkflowServiceServer
 }
 
+// NewCronWorkflowServer creates a new CronWorkflowServer
 func NewCronWorkflowServer() *CronWorkflowServer {
 	return &CronWorkflowServer{}
 }

server/label_server.go

@@ -49,10 +49,12 @@ func mapKeyValuesToMap(keyValues []*api.KeyValue) map[string]string {
 	return result
 }
 
+// LabelServer is an implementation of the grpc LabelServer
 type LabelServer struct {
 	api.UnimplementedLabelServiceServer
 }
 
+// NewLabelServer creates a new LabelServer
 func NewLabelServer() *LabelServer {
 	return &LabelServer{}
 }

server/namespace_server.go

@@ -10,10 +10,12 @@ import (
 	"github.com/onepanelio/core/server/auth"
 )
 
+// NamespaceServer is an implementation of the grpc NamespaceServer
 type NamespaceServer struct {
 	api.UnimplementedNamespaceServiceServer
 }
 
+// NewNamespaceServer creates a new NamespaceServer
 func NewNamespaceServer() *NamespaceServer {
 	return &NamespaceServer{}
 }

server/secret_server.go

@@ -9,10 +9,12 @@ import (
 	"github.com/onepanelio/core/server/auth"
 )
 
+// SecretServer is an implementation of the grpc SecretServer
 type SecretServer struct {
 	api.UnimplementedSecretServiceServer
 }
 
+// NewSecretServer creates a new SecretServer
 func NewSecretServer() *SecretServer {
 	return &SecretServer{}
 }

server/workflow_server.go

@@ -25,10 +25,12 @@ import (
 	requestSort "github.com/onepanelio/core/pkg/util/request/sort"
 )
 
+// WorkflowServer is an implementation of the grpc WorkflowServer
 type WorkflowServer struct {
 	api.UnimplementedWorkflowServiceServer
 }
 
+// NewWorkflowServer creates a new WorkflowServer
 func NewWorkflowServer() *WorkflowServer {
 	return &WorkflowServer{}
 }

server/workflow_template_server.go

@@ -11,10 +11,12 @@ import (
 	"github.com/onepanelio/core/server/converter"
 )
 
+// WorkflowTemplateServer is an implementation of the grpc WorkflowTemplateServer
 type WorkflowTemplateServer struct {
 	api.UnimplementedWorkflowTemplateServiceServer
 }
 
+// NewWorkflowTemplateServer creates a new WorkflowTemplateServer
 func NewWorkflowTemplateServer() *WorkflowTemplateServer {
 	return &WorkflowTemplateServer{}
 }

server/workspace_server.go

@@ -21,10 +21,16 @@ var reservedWorkspaceNames = map[string]bool{
 	"modeldb": true,
 }
 
+// WorkspaceServer is an implementation of the grpc WorkspaceServer
 type WorkspaceServer struct {
 	api.UnimplementedWorkspaceServiceServer
 }
 
+// NewWorkspaceServer creates a new WorkspaceServer
+func NewWorkspaceServer() *WorkspaceServer {
+	return &WorkspaceServer{}
+}
+
 func apiWorkspace(wt *v1.Workspace, config v1.SystemConfig) *api.Workspace {
 	protocol := config.APIProtocol()
 	domain := config.Domain()
@@ -82,10 +88,6 @@ func apiWorkspace(wt *v1.Workspace, config v1.SystemConfig) *api.Workspace {
 	return res
 }
 
-func NewWorkspaceServer() *WorkspaceServer {
-	return &WorkspaceServer{}
-}
-
 func (s *WorkspaceServer) CreateWorkspace(ctx context.Context, req *api.CreateWorkspaceRequest) (*api.Workspace, error) {
 	client := getClient(ctx)
 	allowed, err := auth.IsAuthorized(client, req.Namespace, "create", "onepanel.io", "workspaces", "")

server/workspace_template_server.go

@@ -14,10 +14,16 @@ import (
 	"time"
 )
 
+// WorkspaceTemplateServer is an implementation of the grpc WorkspaceTemplateServer
 type WorkspaceTemplateServer struct {
 	api.UnimplementedWorkspaceTemplateServiceServer
 }
 
+// NewWorkspaceTemplateServer creates a new WorkspaceTemplateServer
+func NewWorkspaceTemplateServer() *WorkspaceTemplateServer {
+	return &WorkspaceTemplateServer{}
+}
+
 func apiWorkspaceTemplate(wt *v1.WorkspaceTemplate) *api.WorkspaceTemplate {
 	res := &api.WorkspaceTemplate{
 		Uid:         wt.UID,
@@ -37,10 +43,6 @@ func apiWorkspaceTemplate(wt *v1.WorkspaceTemplate) *api.WorkspaceTemplate {
 	return res
 }
 
-func NewWorkspaceTemplateServer() *WorkspaceTemplateServer {
-	return &WorkspaceTemplateServer{}
-}
-
 func (s WorkspaceTemplateServer) GenerateWorkspaceTemplateWorkflowTemplate(ctx context.Context, req *api.GenerateWorkspaceTemplateWorkflowTemplateRequest) (*api.WorkflowTemplate, error) {
 	client := getClient(ctx)
 	allowed, err := auth.IsAuthorized(client, req.Namespace, "get", "argoproj.io", "workflowtemplates", "")