zishuo/netmaker
1
0
Fork 0
mirror of https://github.com/gravitl/netmaker.git synced 2025-10-31 12:16:29 +08:00
Code Issues Packages Projects Releases Wiki Activity

remove unnecessary test

Browse Source
This commit is contained in:
0xdcarns
2022-04-25 13:28:00 -04:00
parent 61e5ae9d02
commit 1b17bcd087
1 changed files with 7 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
controllers/dns_test.go
View File

@@ -316,13 +316,13 @@ func TestValidateDNSUpdate(t *testing.T) {
assert.NotNil(t, err)
assert.Contains(t, err.Error(), "Field validation for 'Network' failed on the 'network_exists' tag")
})
t.Run("EmptyAddress", func(t *testing.T) {
//this can't actually happen as change.Address is populated if is blank
change := models.DNSEntry{"", "", "myhost", "skynet"}
err := logic.ValidateDNSUpdate(change, entry)
assert.NotNil(t, err)
assert.Contains(t, err.Error(), "Field validation for 'Address' failed on the 'required' tag")
})
// t.Run("EmptyAddress", func(t *testing.T) {
// //this can't actually happen as change.Address is populated if is blank
// change := models.DNSEntry{"", "", "myhost", "skynet"}
// err := logic.ValidateDNSUpdate(change, entry)
// assert.NotNil(t, err)
// assert.Contains(t, err.Error(), "Field validation for 'Address' failed on the 'required' tag")
// })
t.Run("BadAddress", func(t *testing.T) {
change := models.DNSEntry{"10.0.256.1", "", "myhost", "skynet"}
err := logic.ValidateDNSUpdate(change, entry)