zishuo/mps
1
0
Fork 0
mirror of https://github.com/telanflow/mps.git synced 2025-09-26 20:41:25 +08:00
Code Issues Packages Projects Releases Wiki Activity

Fix data race in MITM'ed HTTPS request handling.[comment](https://github.com/golang/go/issues/61596#issuecomment-1652345131)

Browse Source
This commit is contained in:
telan
2023-09-01 14:12:45 +08:00
parent e7f816b110
commit 5a2b7e7866
1 changed files with 14 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
context.go
View File

@@ -101,12 +101,13 @@ func (ctx *Context) UseFunc(fns ...MiddlewareFunc) {
// Next to exec middlewares
// Execute the next middleware as a linked list. "ctx.Next(req)"
// eg:
// func Handle(req *http.Request, ctx *Context) (*http.Response, error) {
// // You can do anything to modify the http.Request ...
// resp, err := ctx.Next(req)
// // You can do anything to modify the http.Response ...
// return resp, err
// }
//
// func Handle(req *http.Request, ctx *Context) (*http.Response, error) {
// // You can do anything to modify the http.Request ...
// resp, err := ctx.Next(req)
// // You can do anything to modify the http.Response ...
// return resp, err
// }
//
// Alternatively, you can simply return the response without executing `ctx.Next()`,
// which will interrupt subsequent middleware execution.
@@ -132,7 +133,13 @@ func (ctx *Context) Next(req *http.Request) (*http.Response, error) {
if isWebSocketRequest(req) {
return nil, RequestWebsocketUpgradeErr
}
return ctx.RoundTrip(req)
return func() (*http.Response, error) {
// explicitly discard request body to avoid data races in certain RoundTripper implementations
// see https://github.com/golang/go/issues/61596#issuecomment-1652345131
defer req.Body.Close()
return ctx.RoundTrip(req)
}()
}
middleware := ctx.middlewares[ctx.mi]