mirror of
https://github.com/gofiber/storage.git
synced 2025-12-19 00:38:24 +08:00
a3e93a4171
Problem: The memory storage uses string keys and byte slice values directly in a Go map without copying them. When these strings/slices are backed by pooled buffers (from sync.Pool used by Fiber for performance), the map keys and values can become corrupted when those buffers are reused. Root Cause: 1. Fiber v3 uses sync.Pool extensively for byte buffer reuse 2. Strings created from pooled buffers point to the underlying pooled memory 3. When used as Go map keys without copying, these strings share the pooled buffer 4. When the buffer is returned to the pool and reused, the map key gets corrupted 5. This causes intermittent failures where sessions/CSRF tokens cannot be found Solution: Copy both the key (string) and value ([]byte) before storing in the map. Since this package doesn't have access to gofiber/utils, we use manual copying: - Key: string([]byte(key)) - creates a new string with a new backing array - Value: make new slice and copy bytes Testing: - Before fix: ~8% pass rate with ginkgo --repeat=100 - After fix: 100% pass rate with ginkgo --repeat=200 - No corrupted keys found in storage after fix Impact: - Performance: Minimal - one string copy and one byte slice copy per Set - Safety: Prevents entire class of memory corruption bugs - Consistency: Aligns with the fix applied to gofiber/fiber internal storage
title, description, sidebar_position
| title | description | sidebar_position |
|---|---|---|
| 👋 Welcome | 📦 Premade storage drivers for 🚀 Fiber. | 1 |
Premade storage drivers that implement the Storage interface, designed to be used with various Fiber middlewares.
// Storage interface for communicating with different database/key-value
// providers. Visit https://github.com/gofiber/storage for more info.
type Storage interface {
// Get gets the value for the given key.
// `nil, nil` is returned when the key does not exist
Get(key string) ([]byte, error)
// Set stores the given value for the given key along
// with an expiration value, 0 means no expiration.
// Empty key or value will be ignored without an error.
Set(key string, val []byte, exp time.Duration) error
// Delete deletes the value for the given key.
// It returns no error if the storage does not contain the key,
Delete(key string) error
// Reset resets the storage and delete all keys.
Reset() error
// Close closes the storage and will stop any running garbage
// collectors and open connections.
Close() error
}
