package/gortsplib
1
0
Fork 0
mirror of https://github.com/aler9/gortsplib synced 2025-10-05 23:26:54 +08:00
Code Issues Packages Projects Releases Wiki Activity

client: omit mode from Transport header (#611) (#574) (#614)

Browse Source
This commit is contained in:
Alessandro Ros
2024-09-09 10:28:34 +02:00
committed by GitHub
parent 8198405d48
commit c9bf79f340
3 changed files with 6 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
client.go
View File

@@ -1288,9 +1288,8 @@ func (c *Client) doSetup(
v := headers.TransportModeRecord v := headers.TransportModeRecord
return &v return &v
} }
// when playing, omit mode, since it causes errors with some servers.
v := headers.TransportModePlay return nil
return &v
}(), }(),
} }

2
client_play_test.go
View File

@@ -344,6 +344,8 @@ func TestClientPlay(t *testing.T) {
err2 = inTH.Unmarshal(req.Header["Transport"]) err2 = inTH.Unmarshal(req.Header["Transport"])
require.NoError(t, err2) require.NoError(t, err2)
require.Equal(t, (*headers.TransportMode)(nil), inTH.Mode)
var th headers.Transport var th headers.Transport
switch transport { switch transport {

2
client_record_test.go
View File

@@ -200,6 +200,8 @@ func TestClientRecordSerial(t *testing.T) {
err2 = inTH.Unmarshal(req.Header["Transport"]) err2 = inTH.Unmarshal(req.Header["Transport"])
require.NoError(t, err2) require.NoError(t, err2)
require.Equal(t, headers.TransportModeRecord, *inTH.Mode)
var l1 net.PacketConn var l1 net.PacketConn
var l2 net.PacketConn var l2 net.PacketConn
if transport == "udp" { if transport == "udp" {