From c9bf79f340c7731c952c7597ea8e78e826dafc4f Mon Sep 17 00:00:00 2001
From: Alessandro Ros <aler9.dev@gmail.com>
Date: Mon, 9 Sep 2024 10:28:34 +0200
Subject: [PATCH] client: omit mode from Transport header (#611) (#574) (#614)

---
 client.go             | 5 ++---
 client_play_test.go   | 2 ++
 client_record_test.go | 2 ++
 3 files changed, 6 insertions(+), 3 deletions(-)

diff --git a/client.go b/client.go
index e7d75157..e169e192 100644
--- a/client.go
+++ b/client.go
@@ -1288,9 +1288,8 @@ func (c *Client) doSetup(
 				v := headers.TransportModeRecord
 				return &v
 			}
-
-			v := headers.TransportModePlay
-			return &v
+			// when playing, omit mode, since it causes errors with some servers.
+			return nil
 		}(),
 	}
 
diff --git a/client_play_test.go b/client_play_test.go
index f505598f..722617c9 100644
--- a/client_play_test.go
+++ b/client_play_test.go
@@ -344,6 +344,8 @@ func TestClientPlay(t *testing.T) {
 					err2 = inTH.Unmarshal(req.Header["Transport"])
 					require.NoError(t, err2)
 
+					require.Equal(t, (*headers.TransportMode)(nil), inTH.Mode)
+
 					var th headers.Transport
 
 					switch transport {
diff --git a/client_record_test.go b/client_record_test.go
index 07b03478..88c4c972 100644
--- a/client_record_test.go
+++ b/client_record_test.go
@@ -200,6 +200,8 @@ func TestClientRecordSerial(t *testing.T) {
 				err2 = inTH.Unmarshal(req.Header["Transport"])
 				require.NoError(t, err2)
 
+				require.Equal(t, headers.TransportModeRecord, *inTH.Mode)
+
 				var l1 net.PacketConn
 				var l2 net.PacketConn
 				if transport == "udp" {