package/go-gst
1
0
Fork 0
mirror of https://github.com/go-gst/go-gst.git synced 2025-09-26 20:11:18 +08:00
Code Issues Packages Projects Releases Wiki Activity

webrtc: fix nil deref marshal *SessionDescription

Browse Source 
When the SessionDescription pointer is nil, ToGValue() will crash
dereferencing the pointer. Fix this by avoiding the dereference.

The ability to marshal a NULL value is required for compatibility with
other languages. This change has been tested with the custom signalling
from gst-plugins-rs, in which a signaller may emit a `session-requested`
signal with an optional offer SDP.
This commit is contained in:
Chris Bainbridge
2024-10-28 09:45:02 +00:00
parent 7bc995c4f5
commit 2208901b27
1 changed files with 5 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
gst/gstwebrtc/session_description.go
View File

@@ -104,7 +104,11 @@ func (sd *SessionDescription) ToGValue() (*glib.Value, error) {
if err != nil {
return nil, err
}
val.SetBoxed(unsafe.Pointer(sd.ptr))
var ptr *C.GstWebRTCSessionDescription
if sd != nil {
ptr = sd.ptr
}
val.SetBoxed(unsafe.Pointer(ptr))
return val, nil
}