mirror of
https://github.com/pion/webrtc.git
synced 2025-10-05 15:16:52 +08:00
4ff9196a91
It's possible that the ICE gathering is completed after the execution goes to the else statement but before the setGatherCompleteHandler finishes. In other words, it's possible that the handler misses the event and block the caller forever.
25 lines
1.1 KiB
Go
25 lines
1.1 KiB
Go
package webrtc
|
|
|
|
import (
|
|
"context"
|
|
)
|
|
|
|
// GatheringCompletePromise is a Pion specific helper function that returns a channel that is closed when gathering is complete.
|
|
// This function may be helpful in cases where you are unable to trickle your ICE Candidates.
|
|
//
|
|
// It is better to not use this function, and instead trickle candidates. If you use this function you will see longer connection startup times.
|
|
// When the call is connected you will see no impact however.
|
|
func GatheringCompletePromise(pc *PeerConnection) (gatherComplete <-chan struct{}) {
|
|
gatheringComplete, done := context.WithCancel(context.Background())
|
|
|
|
// It's possible to miss the GatherComplete event since setGatherCompleteHandler is an atomic operation and the
|
|
// promise might have been created after the gathering is finished. Therefore, we need to check if the ICE gathering
|
|
// state has changed to complete so that we don't block the caller forever.
|
|
pc.setGatherCompleteHandler(func() { done() })
|
|
if pc.ICEGatheringState() == ICEGatheringStateComplete {
|
|
done()
|
|
}
|
|
|
|
return gatheringComplete.Done()
|
|
}
|