mirror of
https://github.com/pion/webrtc.git
synced 2025-10-04 14:53:05 +08:00
Avoid leaking tickers
In Go 1.22 and earlier, a ticker needs to be explicitly stopped when it's no longer useful in order to avoid a resource leak. In Go 1.23 and later, an orphaned ticker will eventually be garbage collected, but it's still more thrifty to stop it early.
This commit is contained in:

committed by
Sean DuBois

parent
cbbb1c29e5
commit
f29ef99b22
@@ -159,7 +159,9 @@ func ReadLoop(d io.Reader) {
|
||||
|
||||
// WriteLoop shows how to write to the datachannel directly
|
||||
func WriteLoop(d io.Writer) {
|
||||
for range time.NewTicker(5 * time.Second).C {
|
||||
ticker := time.NewTicker(5 * time.Second)
|
||||
defer ticker.Stop()
|
||||
for range ticker.C {
|
||||
message, err := randutil.GenerateCryptoRandomString(messageSize, "abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ")
|
||||
if err != nil {
|
||||
handleError(err)
|
||||
|
Reference in New Issue
Block a user