From e0181e91e1fd75d9096fa1e26a07b5da2a2bb75c Mon Sep 17 00:00:00 2001 From: Sean DuBois Date: Fri, 19 Sep 2025 16:41:51 -0400 Subject: [PATCH] Update TestPeerConnection_SessionID to run on WASM Relates to #2714 --- peerconnection_go_test.go | 39 --------------------------------- peerconnection_test.go | 45 +++++++++++++++++++++++++++++++++++++++ 2 files changed, 45 insertions(+), 39 deletions(-) diff --git a/peerconnection_go_test.go b/peerconnection_go_test.go index bf57f45c..918d5093 100644 --- a/peerconnection_go_test.go +++ b/peerconnection_go_test.go @@ -1425,45 +1425,6 @@ func TestPeerConnection_MediaDirectionInSDP(t *testing.T) { } } -func TestPeerConnection_SessionID(t *testing.T) { - defer test.TimeOut(time.Second * 10).Stop() - defer test.CheckRoutines(t)() - - pcOffer, pcAnswer, err := newPair() - assert.NoError(t, err) - var offerSessionID uint64 - var offerSessionVersion uint64 - var answerSessionID uint64 - var answerSessionVersion uint64 - for i := 0; i < 10; i++ { - assert.NoError(t, signalPair(pcOffer, pcAnswer)) - offer := pcOffer.LocalDescription().parsed - sessionID := offer.Origin.SessionID - sessionVersion := offer.Origin.SessionVersion - if offerSessionID == 0 { - offerSessionID = sessionID - offerSessionVersion = sessionVersion - } else { - assert.Equalf(t, offerSessionID, sessionID, "offer[%v] session id mismatch", i) - assert.Equalf(t, offerSessionVersion+1, sessionVersion, "offer[%v] session version mismatch", i) - offerSessionVersion++ - } - - answer := pcAnswer.LocalDescription().parsed - sessionID = answer.Origin.SessionID - sessionVersion = answer.Origin.SessionVersion - if answerSessionID == 0 { - answerSessionID = sessionID - answerSessionVersion = sessionVersion - } else { - assert.Equalf(t, answerSessionID, sessionID, "answer[%v] session id mismatch", i) - assert.Equalf(t, answerSessionVersion+1, sessionVersion, "answer[%v] session version mismatch", i) - answerSessionVersion++ - } - } - closePairNow(t, pcOffer, pcAnswer) -} - func TestPeerConnectionNilCallback(t *testing.T) { pc, err := NewPeerConnection(Configuration{}) assert.NoError(t, err) diff --git a/peerconnection_test.go b/peerconnection_test.go index f696788c..084107e0 100644 --- a/peerconnection_test.go +++ b/peerconnection_test.go @@ -761,3 +761,48 @@ func TestDTLSClose(t *testing.T) { peerConnectionsConnected.Wait() assert.NoError(t, pcOffer.Close()) } + +func TestPeerConnection_SessionID(t *testing.T) { + defer test.TimeOut(time.Second * 10).Stop() + defer test.CheckRoutines(t)() + + pcOffer, pcAnswer, err := newPair() + assert.NoError(t, err) + var offerSessionID uint64 + var offerSessionVersion uint64 + var answerSessionID uint64 + var answerSessionVersion uint64 + for i := 0; i < 10; i++ { + assert.NoError(t, signalPair(pcOffer, pcAnswer)) + var offer sdp.SessionDescription + assert.NoError(t, offer.UnmarshalString(pcOffer.LocalDescription().SDP)) + + sessionID := offer.Origin.SessionID + sessionVersion := offer.Origin.SessionVersion + + if offerSessionID == 0 { + offerSessionID = sessionID + offerSessionVersion = sessionVersion + } else { + assert.Equalf(t, offerSessionID, sessionID, "offer[%v] session id mismatch", i) + assert.Equalf(t, offerSessionVersion+1, sessionVersion, "offer[%v] session version mismatch", i) + offerSessionVersion++ + } + + var answer sdp.SessionDescription + assert.NoError(t, offer.UnmarshalString(pcAnswer.LocalDescription().SDP)) + + sessionID = answer.Origin.SessionID + sessionVersion = answer.Origin.SessionVersion + + if answerSessionID == 0 { + answerSessionID = sessionID + answerSessionVersion = sessionVersion + } else { + assert.Equalf(t, answerSessionID, sessionID, "answer[%v] session id mismatch", i) + assert.Equalf(t, answerSessionVersion+1, sessionVersion, "answer[%v] session version mismatch", i) + answerSessionVersion++ + } + } + closePairNow(t, pcOffer, pcAnswer) +}