zishuo/webrtc
1
0
Fork 0
mirror of https://github.com/pion/webrtc.git synced 2025-11-03 09:40:59 +08:00
Code Issues Packages Projects Releases Wiki Activity

Fix RTPSender.Send crash

Browse Source 
If PeerConnection removes track while RTPSender is
created and being negotiated, RTPSender.Send would
access nil pointer. Check If track is nil.

Relates to #2065
This commit is contained in:
Len
2022-01-08 00:33:07 +09:00
committed by Sean DuBois
parent dd9d4c503c
commit d4b645635c
3 changed files with 61 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

56
rtpsender_test.go
View File

@@ -271,3 +271,59 @@ func Test_RTPSender_GetParameters_NilTrack(t *testing.T) {
assert.NoError(t, peerConnection.Close())
}
func Test_RTPSender_Send(t *testing.T) {
track, err := NewTrackLocalStaticSample(RTPCodecCapability{MimeType: MimeTypeVP8}, "video", "pion")
assert.NoError(t, err)
peerConnection, err := NewPeerConnection(Configuration{})
assert.NoError(t, err)
rtpSender, err := peerConnection.AddTrack(track)
assert.NoError(t, err)
parameter := rtpSender.GetParameters()
err = rtpSender.Send(parameter)
<-rtpSender.sendCalled
assert.NoError(t, err)
assert.NoError(t, peerConnection.Close())
}
func Test_RTPSender_Send_Called_Once(t *testing.T) {
track, err := NewTrackLocalStaticSample(RTPCodecCapability{MimeType: MimeTypeVP8}, "video", "pion")
assert.NoError(t, err)
peerConnection, err := NewPeerConnection(Configuration{})
assert.NoError(t, err)
rtpSender, err := peerConnection.AddTrack(track)
assert.NoError(t, err)
parameter := rtpSender.GetParameters()
err = rtpSender.Send(parameter)
<-rtpSender.sendCalled
assert.NoError(t, err)
err = rtpSender.Send(parameter)
assert.Equal(t, errRTPSenderSendAlreadyCalled, err)
assert.NoError(t, peerConnection.Close())
}
func Test_RTPSender_Send_Track_Removed(t *testing.T) {
track, err := NewTrackLocalStaticSample(RTPCodecCapability{MimeType: MimeTypeVP8}, "video", "pion")
assert.NoError(t, err)
peerConnection, err := NewPeerConnection(Configuration{})
assert.NoError(t, err)
rtpSender, err := peerConnection.AddTrack(track)
assert.NoError(t, err)
parameter := rtpSender.GetParameters()
assert.NoError(t, peerConnection.RemoveTrack(rtpSender))
assert.Equal(t, errRTPSenderTrackRemoved, rtpSender.Send(parameter))
assert.NoError(t, peerConnection.Close())
}