zishuo/webrtc
1
0
Fork 0
mirror of https://github.com/pion/webrtc.git synced 2025-09-27 03:25:58 +08:00
Code Issues Packages Projects Releases Wiki Activity

Don't cache SessionDescription during unmarshal

Browse Source 
A user could use these across multiple interactions with the API. This
is confusing behavior because all their subsequent calls will be
ignored.

This reverts 3412dc6d95
This commit is contained in:
Mindgamesnl
2021-02-16 21:31:08 +01:00
committed by Sean DuBois
parent 24f350c926
commit cad7b6d34e
3 changed files with 11 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
sessiondescription_test.go
View File

@@ -2,6 +2,7 @@ package webrtc
import (
"encoding/json"
"reflect"
"testing"
"github.com/stretchr/testify/assert"
@@ -68,12 +69,15 @@ func TestSessionDescription_Unmarshal(t *testing.T) {
SDP: offer.SDP,
}
assert.Nil(t, desc.parsed)
parsed, err := desc.Unmarshal()
assert.NotNil(t, parsed)
parsed1, err := desc.Unmarshal()
assert.NotNil(t, parsed1)
assert.NotNil(t, desc.parsed)
assert.NoError(t, err)
parsed, err = desc.Unmarshal()
assert.NotNil(t, parsed)
assert.NoError(t, err)
parsed2, err2 := desc.Unmarshal()
assert.NotNil(t, parsed2)
assert.NoError(t, err2)
assert.NoError(t, pc.Close())
// check if the two parsed results _really_ match, could be affected by internal caching
assert.True(t, reflect.DeepEqual(parsed1, parsed2))
}