mirror of
https://github.com/pion/webrtc.git
synced 2025-10-04 06:46:35 +08:00
Disable MediaEngine Copy by Default
If an API is shared between PeerConnections they would use the same MediaEngine. A MediaEngine contains negotiated PayloadTypes so if the PeerConnections were answering you would end up in invalid states. Add DisableMediaEngineCopy to SettingEngine in case user needs old behavior. Resolves #1662
This commit is contained in:
@@ -139,3 +139,46 @@ func TestSettingEngine_SetICETCP(t *testing.T) {
|
||||
|
||||
assert.Equal(t, tcpMux, settingEngine.iceTCPMux)
|
||||
}
|
||||
|
||||
func TestSettingEngine_SetDisableMediaEngineCopy(t *testing.T) {
|
||||
t.Run("Copy", func(t *testing.T) {
|
||||
m := &MediaEngine{}
|
||||
assert.NoError(t, m.RegisterDefaultCodecs())
|
||||
|
||||
offerer, answerer, err := NewAPI(WithMediaEngine(m)).newPair(Configuration{})
|
||||
assert.NoError(t, err)
|
||||
|
||||
_, err = offerer.AddTransceiverFromKind(RTPCodecTypeVideo)
|
||||
assert.NoError(t, err)
|
||||
|
||||
assert.NoError(t, signalPair(offerer, answerer))
|
||||
|
||||
assert.False(t, m.negotiatedVideo)
|
||||
assert.Empty(t, m.negotiatedVideoCodecs)
|
||||
|
||||
assert.NoError(t, offerer.Close())
|
||||
assert.NoError(t, answerer.Close())
|
||||
})
|
||||
|
||||
t.Run("No Copy", func(t *testing.T) {
|
||||
m := &MediaEngine{}
|
||||
assert.NoError(t, m.RegisterDefaultCodecs())
|
||||
|
||||
s := SettingEngine{}
|
||||
s.DisableMediaEngineCopy(true)
|
||||
|
||||
offerer, answerer, err := NewAPI(WithMediaEngine(m), WithSettingEngine(s)).newPair(Configuration{})
|
||||
assert.NoError(t, err)
|
||||
|
||||
_, err = offerer.AddTransceiverFromKind(RTPCodecTypeVideo)
|
||||
assert.NoError(t, err)
|
||||
|
||||
assert.NoError(t, signalPair(offerer, answerer))
|
||||
|
||||
assert.True(t, m.negotiatedVideo)
|
||||
assert.NotEmpty(t, m.negotiatedVideoCodecs)
|
||||
|
||||
assert.NoError(t, offerer.Close())
|
||||
assert.NoError(t, answerer.Close())
|
||||
})
|
||||
}
|
||||
|
Reference in New Issue
Block a user