zishuo/webrtc
1
0
Fork 0
mirror of https://github.com/pion/webrtc.git synced 2025-10-05 07:06:51 +08:00
Code Issues Packages Projects Releases Wiki Activity

Fix the zero value of ICECredentialType

Browse Source 
Ensure that the zero value of ICECredentialType is password.
This commit is contained in:
Juliusz Chroboczek
2022-05-11 02:17:02 +02:00
committed by Sean DuBois
parent 37a145a51f
commit b4579949e1
5 changed files with 36 additions and 25 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
peerconnection_js.go
View File

@@ -640,12 +640,16 @@ func valueToICECredential(iceCredentialValue js.Value) interface{} {
}
func valueToICEServer(iceServerValue js.Value) ICEServer {
tpe, err := newICECredentialType(valueToStringOrZero(iceServerValue.Get("credentialType")))
if err != nil {
tpe = ICECredentialTypePassword
}
s := ICEServer{
URLs: valueToStrings(iceServerValue.Get("urls")), // required
Username: valueToStringOrZero(iceServerValue.Get("username")),
// Note: Credential and CredentialType are not currently supported.
Credential: valueToICECredential(iceServerValue.Get("credential")),
CredentialType: newICECredentialType(valueToStringOrZero(iceServerValue.Get("credentialType"))),
CredentialType: tpe,
}
// default to password