zishuo/webrtc
1
0
Fork 0
mirror of https://github.com/pion/webrtc.git synced 2025-10-31 18:52:55 +08:00
Code Issues Packages Projects Releases Wiki Activity

RTCP: test for unmarshaling nil packet

Browse Source
This commit is contained in:
Max Hawkins
2018-09-10 22:05:38 -07:00
committed by Michiel De Backker
parent 74e2d1e3de
commit 894296d9ab
2 changed files with 10 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
pkg/rtcp/packet.go
View File

@@ -46,6 +46,7 @@ const (
var (
errInvalidVersion = errors.New("invalid version")
errInvalidReportCount = errors.New("invalid report count")
errHeaderTooShort = errors.New("rtcp header too short")
)
// Marshal encodes the Header in binary
@@ -83,7 +84,7 @@ func (h Header) Marshal() ([]byte, error) {
// Unmarshal decodes the Header from binary
func (h *Header) Unmarshal(rawPacket []byte) error {
if len(rawPacket) < headerLength {
return errors.Errorf("RTCP header size insufficient; %d < %d", len(rawPacket), headerLength)
return errHeaderTooShort
}
/*

8
pkg/rtcp/packet_test.go
View File

@@ -29,6 +29,14 @@ func TestHeaderUnmarshal(t *testing.T) {
t.Fatalf("Unmarshal: got %#v, want %#v", got, want)
}
}
func TestHeaderUnmarshalNil(t *testing.T) {
var header Header
err := header.Unmarshal(nil)
if got, want := err, errHeaderTooShort; got != want {
t.Fatalf("unmarshal nil header: err = %v, want %v", got, want)
}
}
func TestHeaderRoundTrip(t *testing.T) {
for _, test := range []struct {
Name string