zishuo/webrtc
1
0
Fork 0
mirror of https://github.com/pion/webrtc.git synced 2025-10-05 15:16:52 +08:00
Code Issues Packages Projects Releases Wiki Activity

Minor fixes to TestInterceptorNack

Browse Source 
One variable was misnamed, and we never checked for the end
of the RTCP loop.
This commit is contained in:
Juliusz Chroboczek
2025-01-08 16:00:12 +01:00
committed by GitHub
parent b47fbb6b5e
commit 6f6231b062
1 changed files with 4 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
interceptor_test.go
View File

@@ -289,7 +289,7 @@ func Test_Interceptor_ZeroSSRC(t *testing.T) {
} }
// TestInterceptorNack is an end-to-end test for the NACK sender. // TestInterceptorNack is an end-to-end test for the NACK sender.
// It test that: // It tests that:
// - we get a NACK if we negotiated generic NACks; // - we get a NACK if we negotiated generic NACks;
// - we don't get a NACK if we did not negotiate generick NACKs; // - we don't get a NACK if we did not negotiate generick NACKs;
// - the NACK corresponds to the missing packet. // - the NACK corresponds to the missing packet.
@@ -306,16 +306,16 @@ func testInterceptorNack(t *testing.T, requestNack bool) {
ir := interceptor.Registry{} ir := interceptor.Registry{}
m := MediaEngine{} m := MediaEngine{}
var capability []RTCPFeedback var feedback []RTCPFeedback
if requestNack { if requestNack {
capability = append(capability, RTCPFeedback{"nack", ""}) feedback = append(feedback, RTCPFeedback{"nack", ""})
} }
err := m.RegisterCodec( err := m.RegisterCodec(
RTPCodecParameters{ RTPCodecParameters{
RTPCodecCapability: RTPCodecCapability{ RTPCodecCapability: RTPCodecCapability{
"video/VP8", 90000, 0, "video/VP8", 90000, 0,
"", "",
capability, feedback,
}, },
PayloadType: 96, PayloadType: 96,
}, },
@@ -424,7 +424,6 @@ func testInterceptorNack(t *testing.T, requestNack bool) {
assert.NoError(t, err) assert.NoError(t, err)
err = pc2.Close() err = pc2.Close()
assert.NoError(t, err) assert.NoError(t, err)
<-rtcpDone
if requestNack { if requestNack {
if !gotNack { if !gotNack {