zishuo/webrtc
1
0
Fork 0
mirror of https://github.com/pion/webrtc.git synced 2025-09-27 03:25:58 +08:00
Code Issues Packages Projects Releases Wiki Activity

Don't use omitempty for ICECandidateInit

Browse Source 
Always return sdpMid & sdpMLineindex value if it
is null. The W3C starts every attribute definition with
`If not null ...`
This commit is contained in:
JooYoung
2020-08-19 17:48:39 +09:00
committed by Sean DuBois
parent cdc726201b
commit 6d3633e589
5 changed files with 10 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
icecandidateinit_test.go
View File

@@ -16,12 +16,11 @@ func TestICECandidateInit_Serialization(t *testing.T) {
Candidate: "candidate:abc123",
SDPMid: refString("0"),
SDPMLineIndex: refUint16(0),
UsernameFragment: "def",
UsernameFragment: refString("def"),
}, `{"candidate":"candidate:abc123","sdpMid":"0","sdpMLineIndex":0,"usernameFragment":"def"}`},
{ICECandidateInit{
Candidate: "candidate:abc123",
UsernameFragment: "def",
}, `{"candidate":"candidate:abc123","usernameFragment":"def"}`},
Candidate: "candidate:abc123",
}, `{"candidate":"candidate:abc123","sdpMid":null,"sdpMLineIndex":null,"usernameFragment":null}`},
}
for i, tc := range tt {