zishuo/webrtc
1
0
Fork 0
mirror of https://github.com/pion/webrtc.git synced 2025-11-01 19:22:49 +08:00
Code Issues Packages Projects Releases Wiki Activity

Incorporate suggestions from code review

Browse Source 
Review done by Max Hawkins on November 27, 2018
against commit 874b648ba5
Relates to #119
This commit is contained in:
Woodrow Douglass
2018-11-28 11:42:58 -05:00
committed by Max Hawkins
parent af1b2c9520
commit 6a694b33ea
7 changed files with 46 additions and 104 deletions
Download Patch File Download Diff File Expand all files Collapse all files

38
pkg/rtcp/packet.go
View File

@@ -6,7 +6,7 @@ type Packet interface {
Unmarshal(rawPacket []byte) error
}
// PacketWithHeader is a pair to represent an RTCP header and it's
// PacketWithHeader is a pair to represent an RTCP header and its
// packet's polymorphic parsed and unparsed forms.
type PacketWithHeader struct {
Header
@@ -32,51 +32,51 @@ func (p *PacketWithHeader) Unmarshal(rawPacket []byte) error {
case TypeSenderReport:
sr := new(SenderReport)
err := sr.Unmarshal(rawPacket)
if err == nil {
p.Packet = sr
} else {
if err != nil {
return err
}
p.Packet = sr
case TypeReceiverReport:
rr := new(ReceiverReport)
err := rr.Unmarshal(rawPacket)
if err == nil {
p.Packet = rr
} else {
if err != nil {
return err
}
p.Packet = rr
case TypeSourceDescription:
sdes := new(SourceDescription)
err := sdes.Unmarshal(rawPacket)
if err == nil {
p.Packet = sdes
} else {
if err != nil {
return err
}
p.Packet = sdes
case TypeGoodbye:
bye := new(Goodbye)
err := bye.Unmarshal(rawPacket)
if err == nil {
p.Packet = bye
} else {
if err != nil {
return err
}
p.Packet = bye
case TypeTransportSpecificFeedback:
rrr := new(RapidResynchronizationRequest)
err := rrr.Unmarshal(rawPacket)
if err == nil {
p.Packet = rrr
} else {
if err != nil {
return err
}
p.Packet = rrr
case TypePayloadSpecificFeedback:
psfb := new(PictureLossIndication)
err := psfb.Unmarshal(rawPacket)
if err == nil {
p.Packet = psfb
} else {
if err != nil {
return err
}
p.Packet = psfb
default:
return errWrongType
}