zishuo/webrtc
1
0
Fork 0
mirror of https://github.com/pion/webrtc.git synced 2025-10-06 23:52:51 +08:00
Code Issues Packages Projects Releases Wiki Activity

Fix poorly named function in RTCPeerConnection

Browse Source 
CreateOffer -> CreateAnswer currently `pion-WebRTC` can only generate
offers not answers.
This commit is contained in:
Sean DuBois
2018-07-04 00:46:01 -07:00
parent 3b3ed9a544
commit 24a312c34d
4 changed files with 8 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
examples/gstreamer-receive/main.go
View File

@@ -55,7 +55,7 @@ func main() {
} }
// Sets the LocalDescription, and starts our UDP listeners // Sets the LocalDescription, and starts our UDP listeners
if err := peerConnection.CreateOffer(); err != nil { if err := peerConnection.CreateAnswer(); err != nil {
panic(err) panic(err)
} }

2
examples/gstreamer-send/main.go
View File

@@ -48,7 +48,7 @@ func main() {
} }
// Sets the LocalDescription, and starts our UDP listeners // Sets the LocalDescription, and starts our UDP listeners
if err := peerConnection.CreateOffer(); err != nil { if err := peerConnection.CreateAnswer(); err != nil {
panic(err) panic(err)
} }

2
examples/save-to-disk/main.go
View File

@@ -57,7 +57,7 @@ func main() {
} }
// Sets the LocalDescription, and starts our UDP listeners // Sets the LocalDescription, and starts our UDP listeners
if err := peerConnection.CreateOffer(); err != nil { if err := peerConnection.CreateAnswer(); err != nil {
panic(err) panic(err)
} }

7
rtcpeerconnection.go
View File

@@ -83,9 +83,12 @@ func (r *RTCPeerConnection) SetRemoteDescription(rawSessionDescription string) e
} }
// CreateOffer starts the RTCPeerConnection and generates the localDescription // CreateOffer starts the RTCPeerConnection and generates the localDescription
// The order of CreateOffer/SetRemoteDescription determines if we are the offerer or the answerer
// Once the RemoteDescription has been set network activity will start
func (r *RTCPeerConnection) CreateOffer() error { func (r *RTCPeerConnection) CreateOffer() error {
return errors.Errorf("CreateOffer is not implemented")
}
// CreateAnswer starts the RTCPeerConnection and generates the localDescription
func (r *RTCPeerConnection) CreateAnswer() error {
if r.tlscfg != nil { if r.tlscfg != nil {
return errors.Errorf("tlscfg is already defined, CreateOffer can only be called once") return errors.Errorf("tlscfg is already defined, CreateOffer can only be called once")
} }