From 22cf05c358717e8627d5f69399e9edf28966475e Mon Sep 17 00:00:00 2001 From: Joe Turki Date: Sat, 16 Aug 2025 18:24:54 +0300 Subject: [PATCH] Upgrade to golangci-lint@v2 --- peerconnection.go | 2 +- peerconnection_close_test.go | 10 ++-------- 2 files changed, 3 insertions(+), 9 deletions(-) diff --git a/peerconnection.go b/peerconnection.go index 50b05cd0..61264459 100644 --- a/peerconnection.go +++ b/peerconnection.go @@ -2089,7 +2089,7 @@ func (pc *PeerConnection) AddTrack(track TrackLocal) (*RTPSender, error) { // But that will cause sdp inflate. So we only check currentDirection's current value, // that's worked for all browsers. if transceiver.kind == track.Kind() && transceiver.Sender() == nil && - !(currentDirection == RTPTransceiverDirectionSendrecv || currentDirection == RTPTransceiverDirectionSendonly) { + currentDirection != RTPTransceiverDirectionSendrecv && currentDirection != RTPTransceiverDirectionSendonly { sender, err := pc.api.NewRTPSender(track, pc.dtlsTransport) if err == nil { err = transceiver.SetSender(sender, track) diff --git a/peerconnection_close_test.go b/peerconnection_close_test.go index 4446519d..f94b2872 100644 --- a/peerconnection_close_test.go +++ b/peerconnection_close_test.go @@ -78,20 +78,14 @@ func TestPeerConnection_Close_PreICE(t *testing.T) { assert.NoError(t, pcAnswer.SetRemoteDescription(answer)) - for { - if pcAnswer.iceTransport.State() == ICETransportStateChecking { - break - } + for pcAnswer.iceTransport.State() != ICETransportStateChecking { time.Sleep(time.Second / 4) } assert.NoError(t, pcAnswer.Close()) // Assert that ICETransport is shutdown, test timeout will prevent deadlock - for { - if pcAnswer.iceTransport.State() == ICETransportStateClosed { - return - } + for pcAnswer.iceTransport.State() != ICETransportStateClosed { time.Sleep(time.Second / 4) } }