zishuo/webrtc
1
0
Fork 0
mirror of https://github.com/pion/webrtc.git synced 2025-09-27 03:25:58 +08:00
Code Issues Packages Projects Releases Wiki Activity

Add opt control transceiver re-use in recvonly

Browse Source 
SetDisableTransceiverReuseInRecvonly controls if a
transceiver is re-used when its current direction is `recvonly`.

This is useful for the following scenario
  - Remote side sends `offer` with `sendonly` media section.
  - Local side creates transceiver in `SetRemoteDescription`
    and sets direction to `recvonly.
  - Local side calls `AddTrack`.
  - As the current direction is `recvonly`, the transceiver added
    above will be re-used. That will set the direction to `sendrecv`
    and the generated `answer` will have `sendrecv` for that
    media section.
  - That answer becomes incompatible as the offerer is using
    `sendonly`.

Note that local transceiver will be in `recvonly` for both `sendrecv`
and `sendonly` directions in the media section. If the `offer` did use
`sendrecv`, it is possible to re-use that transceiver for sending.
So, disabling re-use will prohibit re-use in the `sendrecv` case also
and hence is slightly wasteful.
This commit is contained in:
boks1971
2025-08-22 17:47:52 +05:30
committed by Raja Subramanian
parent 3e84081c87
commit 2299a71701
3 changed files with 104 additions and 28 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
settingengine.go
View File

@@ -110,6 +110,7 @@ type SettingEngine struct {
disableCloseByDTLS bool
dataChannelBlockWrite bool
handleUndeclaredSSRCWithoutAnswer bool
disableTransceiverReuseInRecvonly bool
}
func (e *SettingEngine) getSCTPMaxMessageSize() uint32 {
@@ -577,3 +578,23 @@ func (e *SettingEngine) DisableCloseByDTLS(isEnabled bool) {
func (e *SettingEngine) SetHandleUndeclaredSSRCWithoutAnswer(handleUndeclaredSSRCWithoutAnswer bool) {
e.handleUndeclaredSSRCWithoutAnswer = handleUndeclaredSSRCWithoutAnswer
}
// SetDisableTransceiverReuseInRecvonly controls if a transceiver is re-used
// when its current direction is `recvonly`.
//
// This is useful for the following scenario
// - Remote side sends `offer` with `sendonly` media section.
// - Local side creates transceiver in `SetRemoteDescription` and sets direction to `recvonly`.
// - Local side calls `AddTrack`.
// - As the current direction is `recvonly`, the transceiver added above will be re-used.
// That will set the direction to `sendrecv` and the generated `answer` will have `sendrecv`
// for that media section.
// - That answer becomes incompatible as the offerer is using `sendonly`.
//
// Note that local transceiver will be in `recvonly` for both `sendrecv` and `sendonly` directions
// in the media section. If the `offer` did use `sendrecv`, it is possible to re-use that transceiver
// for sending. So, disabling re-use will prohibit re-use in the `sendrecv` case also and hence is
// slightly wasteful.
func (e *SettingEngine) SetDisableTransceiverReuseInRecvonly(disableTransceiverReuseInRecvonly bool) {
e.disableTransceiverReuseInRecvonly = disableTransceiverReuseInRecvonly
}