zishuo/webrtc
1
0
Fork 0
mirror of https://github.com/pion/webrtc.git synced 2025-09-27 11:32:19 +08:00
Code Issues Packages Projects Releases Wiki Activity

Create WASM covering review

Browse Source 
We have a few things that need to be addressed, I
have ticketed them. We should now completely pass godox!

Resolves #106
This commit is contained in:
Sean DuBois
2019-07-27 01:06:52 -07:00
committed by Sean DuBois
parent 0d768e26f5
commit 0a62e5d4c1
5 changed files with 10 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
datachannel_js.go
View File

@@ -67,7 +67,7 @@ func (d *DataChannel) OnMessage(f func(msg DataChannelMessage)) {
defer oldHandler.Release() defer oldHandler.Release()
} }
onMessageHandler := js.FuncOf(func(this js.Value, args []js.Value) interface{} { onMessageHandler := js.FuncOf(func(this js.Value, args []js.Value) interface{} {
// TODO: Ensure message order? // pion/webrtc/projects/15
data := args[0].Get("data") data := args[0].Get("data")
go func() { go func() {
// valueToDataChannelMessage may block when handling 'Blob' data // valueToDataChannelMessage may block when handling 'Blob' data

4
datachannel_js_detach.go
View File

@@ -19,10 +19,10 @@ func newDetachedDataChannel(dc *DataChannel) *detachedDataChannel {
// Wire up callbacks // Wire up callbacks
dc.OnMessage(func(msg DataChannelMessage) { dc.OnMessage(func(msg DataChannelMessage) {
read <- msg // TODO: Potential leak? read <- msg // pion/webrtc/projects/15
}) })
// TODO: OnClose? // pion/webrtc/projects/15
return &detachedDataChannel{ return &detachedDataChannel{
dc: dc, dc: dc,

9
peerconnection_js.go
View File

@@ -73,10 +73,11 @@ func (pc *PeerConnection) OnDataChannel(f func(*DataChannel)) {
defer oldHandler.Release() defer oldHandler.Release()
} }
onDataChannelHandler := js.FuncOf(func(this js.Value, args []js.Value) interface{} { onDataChannelHandler := js.FuncOf(func(this js.Value, args []js.Value) interface{} {
// BUG(albrow): This reference to the underlying DataChannel doesn't know // pion/webrtc/projects/15
// This reference to the underlying DataChannel doesn't know
// about any other references to the same DataChannel. This might result in // about any other references to the same DataChannel. This might result in
// memory leaks where we don't clean up handler functions. Could possibly // memory leaks where we don't clean up handler functions. Could possibly fix
// fix by keeping a mutex-protected list of all DataChannel references as a // by keeping a mutex-protected list of all DataChannel references as a
// property of this PeerConnection, but at the cost of additional overhead. // property of this PeerConnection, but at the cost of additional overhead.
dataChannel := &DataChannel{ dataChannel := &DataChannel{
underlying: args[0].Get("channel"), underlying: args[0].Get("channel"),
@@ -124,7 +125,7 @@ func (pc *PeerConnection) checkConfiguration(configuration Configuration) error
} }
} }
// TODO: Enable these checks once Certificates are supported. // https://github.com/pion/webrtc/issues/513
// https://www.w3.org/TR/webrtc/#set-the-configuration (step #4) // https://www.w3.org/TR/webrtc/#set-the-configuration (step #4)
// if len(configuration.Certificates) > 0 { // if len(configuration.Certificates) > 0 {
// if len(configuration.Certificates) != len(existingConfiguration.Certificates) { // if len(configuration.Certificates) != len(existingConfiguration.Certificates) {

1
quictransport.go
View File

@@ -125,7 +125,6 @@ func (t *QUICTransport) Start(remoteParameters QUICParameters) error {
} }
// Check the fingerprint if a certificate was exchanged // Check the fingerprint if a certificate was exchanged
// TODO: Check why never received.
remoteCerts := t.TransportBase.GetRemoteCertificates() remoteCerts := t.TransportBase.GetRemoteCertificates()
if len(remoteCerts) > 0 { if len(remoteCerts) > 0 {
err := t.validateFingerPrint(remoteParameters, remoteCerts[0]) err := t.validateFingerPrint(remoteParameters, remoteCerts[0])

4
sctptransport.go
View File

@@ -236,8 +236,8 @@ func (r *SCTPTransport) updateMessageSize() {
r.lock.Lock() r.lock.Lock()
defer r.lock.Unlock() defer r.lock.Unlock()
var remoteMaxMessageSize float64 = 65536 // TODO: get from SDP var remoteMaxMessageSize float64 = 65536 // pion/webrtc#758
var canSendSize float64 = 65536 // TODO: Get from SCTP implementation var canSendSize float64 = 65536 // pion/webrtc#758
r.maxMessageSize = r.calcMessageSize(remoteMaxMessageSize, canSendSize) r.maxMessageSize = r.calcMessageSize(remoteMaxMessageSize, canSendSize)
} }