attributes:error-code: use map instead of swich-case

attribute_errorcode.go

@@ -14,24 +14,21 @@ const (
 	CodeServerError      ErrorCode = 500
 )
 
+var errorReasons = map[ErrorCode]string{
+	CodeTryAlternate:     "Try Alternate",
+	CodeBadRequest:       "Bad Request",
+	CodeUnauthorised:     "Unauthorised",
+	CodeUnknownAttribute: "Unknown Attribute",
+	CodeStaleNonce:       "Stale Nonce",
+	CodeServerError:      "Server Error",
+	CodeRoleConflict:     "Role Conflict",
+}
+
 // Reason returns recommended reason string.
 func (c ErrorCode) Reason() string {
-	switch c {
+	reason, ok := errorReasons[c]
-	case CodeTryAlternate:
+	if !ok {
-		return "Try Alternate"
-	case CodeBadRequest:
-		return "Bad Request"
-	case CodeUnauthorised:
-		return "Unauthorised"
-	case CodeUnknownAttribute:
-		return "Unknown attribute"
-	case CodeStaleNonce:
-		return "Stale Nonce"
-	case CodeServerError:
-		return "Server Error"
-	case CodeRoleConflict:
-		return "Role conflict"
-	default:
 		return "Unknown Error"
 	}
+	return reason
 }

client.go

@@ -8,6 +8,7 @@ import (
 )
 
 // SameTransaction returns true of a and b have same Transaction ID.
+// DEPRECATED: remove usage.
 func SameTransaction(a *Message, b *Message) bool {
 	return a.TransactionID == b.TransactionID
 }