mirror of
https://github.com/opencontainers/runc.git
synced 2025-10-21 14:39:36 +08:00

Fix for the following: $ sudo go test -race -v ./libcontainer/integration/ === RUN TestUsernsCheckpoint ================== WARNING: DATA RACE Write at 0x00c00019e650 by goroutine 15: bytes.(*Buffer).ReadFrom() /usr/lib/golang/src/bytes/buffer.go:200 +0x48 io.copyBuffer() /usr/lib/golang/src/io/io.go:395 +0x3fe io.Copy() /usr/lib/golang/src/io/io.go:368 +0x7a os/exec.(*Cmd).writerDescriptor.func1() /usr/lib/golang/src/os/exec/exec.go:311 +0x4a os/exec.(*Cmd).Start.func1() /usr/lib/golang/src/os/exec/exec.go:441 +0x38 Previous write at 0x00c00019e650 by goroutine 12: bytes.(*Buffer).ReadFrom() /usr/lib/golang/src/bytes/buffer.go:200 +0x48 io.copyBuffer() /usr/lib/golang/src/io/io.go:395 +0x3fe io.Copy() /usr/lib/golang/src/io/io.go:368 +0x7a os/exec.(*Cmd).writerDescriptor.func1() /usr/lib/golang/src/os/exec/exec.go:311 +0x4a os/exec.(*Cmd).Start.func1() /usr/lib/golang/src/os/exec/exec.go:441 +0x38 Goroutine 15 (running) created at: os/exec.(*Cmd).Start() /usr/lib/golang/src/os/exec/exec.go:440 +0xaaa github.com/opencontainers/runc/libcontainer.(*linuxContainer).criuSwrk() /home/kir/go/src/github.com/opencontainers/runc/libcontainer/container_linux.go:1490 +0x5f7 github.com/opencontainers/runc/libcontainer.(*linuxContainer).Restore() /home/kir/go/src/github.com/opencontainers/runc/libcontainer/container_linux.go:1398 +0x29ef github.com/opencontainers/runc/libcontainer/integration.testCheckpoint() /home/kir/go/src/github.com/opencontainers/runc/libcontainer/integration/checkpoint_test.go:204 +0x1898 github.com/opencontainers/runc/libcontainer/integration.TestUsernsCheckpoint() /home/kir/go/src/github.com/opencontainers/runc/libcontainer/integration/checkpoint_test.go:48 +0x177 testing.tRunner() /usr/lib/golang/src/testing/testing.go:1123 +0x202 Goroutine 12 (finished) created at: os/exec.(*Cmd).Start() /usr/lib/golang/src/os/exec/exec.go:440 +0xaaa github.com/opencontainers/runc/libcontainer.(*initProcess).start() /home/kir/go/src/github.com/opencontainers/runc/libcontainer/process_linux.go:313 +0xda github.com/opencontainers/runc/libcontainer.(*linuxContainer).start() /home/kir/go/src/github.com/opencontainers/runc/libcontainer/container_linux.go:366 +0xb0 github.com/opencontainers/runc/libcontainer.(*linuxContainer).Start() /home/kir/go/src/github.com/opencontainers/runc/libcontainer/container_linux.go:263 +0x27b github.com/opencontainers/runc/libcontainer.(*linuxContainer).Run() /home/kir/go/src/github.com/opencontainers/runc/libcontainer/container_linux.go:273 +0x46 github.com/opencontainers/runc/libcontainer/integration.testCheckpoint() /home/kir/go/src/github.com/opencontainers/runc/libcontainer/integration/checkpoint_test.go:108 +0x941 github.com/opencontainers/runc/libcontainer/integration.TestUsernsCheckpoint() /home/kir/go/src/github.com/opencontainers/runc/libcontainer/integration/checkpoint_test.go:48 +0x177 testing.tRunner() /usr/lib/golang/src/testing/testing.go:1123 +0x202 ================== ================== WARNING: DATA RACE Read at 0x00c00019e630 by goroutine 15: bytes.(*Buffer).Len() /usr/lib/golang/src/bytes/buffer.go:73 +0x58 bytes.(*Buffer).grow() /usr/lib/golang/src/bytes/buffer.go:118 +0x4f bytes.(*Buffer).ReadFrom() /usr/lib/golang/src/bytes/buffer.go:202 +0x7c io.copyBuffer() /usr/lib/golang/src/io/io.go:395 +0x3fe io.Copy() /usr/lib/golang/src/io/io.go:368 +0x7a os/exec.(*Cmd).writerDescriptor.func1() /usr/lib/golang/src/os/exec/exec.go:311 +0x4a os/exec.(*Cmd).Start.func1() /usr/lib/golang/src/os/exec/exec.go:441 +0x38 Previous write at 0x00c00019e630 by goroutine 12: bytes.(*Buffer).ReadFrom() /usr/lib/golang/src/bytes/buffer.go:209 +0x1c4 io.copyBuffer() /usr/lib/golang/src/io/io.go:395 +0x3fe io.Copy() /usr/lib/golang/src/io/io.go:368 +0x7a os/exec.(*Cmd).writerDescriptor.func1() /usr/lib/golang/src/os/exec/exec.go:311 +0x4a os/exec.(*Cmd).Start.func1() /usr/lib/golang/src/os/exec/exec.go:441 +0x38 Goroutine 15 (running) created at: os/exec.(*Cmd).Start() /usr/lib/golang/src/os/exec/exec.go:440 +0xaaa github.com/opencontainers/runc/libcontainer.(*linuxContainer).criuSwrk() /home/kir/go/src/github.com/opencontainers/runc/libcontainer/container_linux.go:1490 +0x5f7 github.com/opencontainers/runc/libcontainer.(*linuxContainer).Restore() /home/kir/go/src/github.com/opencontainers/runc/libcontainer/container_linux.go:1398 +0x29ef github.com/opencontainers/runc/libcontainer/integration.testCheckpoint() /home/kir/go/src/github.com/opencontainers/runc/libcontainer/integration/checkpoint_test.go:204 +0x1898 github.com/opencontainers/runc/libcontainer/integration.TestUsernsCheckpoint() /home/kir/go/src/github.com/opencontainers/runc/libcontainer/integration/checkpoint_test.go:48 +0x177 testing.tRunner() /usr/lib/golang/src/testing/testing.go:1123 +0x202 Goroutine 12 (finished) created at: os/exec.(*Cmd).Start() /usr/lib/golang/src/os/exec/exec.go:440 +0xaaa github.com/opencontainers/runc/libcontainer.(*initProcess).start() /home/kir/go/src/github.com/opencontainers/runc/libcontainer/process_linux.go:313 +0xda github.com/opencontainers/runc/libcontainer.(*linuxContainer).start() /home/kir/go/src/github.com/opencontainers/runc/libcontainer/container_linux.go:366 +0xb0 github.com/opencontainers/runc/libcontainer.(*linuxContainer).Start() /home/kir/go/src/github.com/opencontainers/runc/libcontainer/container_linux.go:263 +0x27b github.com/opencontainers/runc/libcontainer.(*linuxContainer).Run() /home/kir/go/src/github.com/opencontainers/runc/libcontainer/container_linux.go:273 +0x46 github.com/opencontainers/runc/libcontainer/integration.testCheckpoint() /home/kir/go/src/github.com/opencontainers/runc/libcontainer/integration/checkpoint_test.go:108 +0x941 github.com/opencontainers/runc/libcontainer/integration.TestUsernsCheckpoint() /home/kir/go/src/github.com/opencontainers/runc/libcontainer/integration/checkpoint_test.go:48 +0x177 testing.tRunner() /usr/lib/golang/src/testing/testing.go:1123 +0x202 ================== ================== WARNING: DATA RACE Read at 0x00c00019e648 by goroutine 15: bytes.(*Buffer).Len() /usr/lib/golang/src/bytes/buffer.go:73 +0x7e bytes.(*Buffer).grow() /usr/lib/golang/src/bytes/buffer.go:118 +0x4f bytes.(*Buffer).ReadFrom() /usr/lib/golang/src/bytes/buffer.go:202 +0x7c io.copyBuffer() /usr/lib/golang/src/io/io.go:395 +0x3fe io.Copy() /usr/lib/golang/src/io/io.go:368 +0x7a os/exec.(*Cmd).writerDescriptor.func1() /usr/lib/golang/src/os/exec/exec.go:311 +0x4a os/exec.(*Cmd).Start.func1() /usr/lib/golang/src/os/exec/exec.go:441 +0x38 Previous write at 0x00c00019e648 by goroutine 12: bytes.(*Buffer).grow() /usr/lib/golang/src/bytes/buffer.go:147 +0x2d7 bytes.(*Buffer).ReadFrom() /usr/lib/golang/src/bytes/buffer.go:202 +0x7c io.copyBuffer() /usr/lib/golang/src/io/io.go:395 +0x3fe io.Copy() /usr/lib/golang/src/io/io.go:368 +0x7a os/exec.(*Cmd).writerDescriptor.func1() /usr/lib/golang/src/os/exec/exec.go:311 +0x4a os/exec.(*Cmd).Start.func1() /usr/lib/golang/src/os/exec/exec.go:441 +0x38 Goroutine 15 (running) created at: os/exec.(*Cmd).Start() /usr/lib/golang/src/os/exec/exec.go:440 +0xaaa github.com/opencontainers/runc/libcontainer.(*linuxContainer).criuSwrk() /home/kir/go/src/github.com/opencontainers/runc/libcontainer/container_linux.go:1490 +0x5f7 github.com/opencontainers/runc/libcontainer.(*linuxContainer).Restore() /home/kir/go/src/github.com/opencontainers/runc/libcontainer/container_linux.go:1398 +0x29ef github.com/opencontainers/runc/libcontainer/integration.testCheckpoint() /home/kir/go/src/github.com/opencontainers/runc/libcontainer/integration/checkpoint_test.go:204 +0x1898 github.com/opencontainers/runc/libcontainer/integration.TestUsernsCheckpoint() /home/kir/go/src/github.com/opencontainers/runc/libcontainer/integration/checkpoint_test.go:48 +0x177 testing.tRunner() /usr/lib/golang/src/testing/testing.go:1123 +0x202 Goroutine 12 (finished) created at: os/exec.(*Cmd).Start() /usr/lib/golang/src/os/exec/exec.go:440 +0xaaa github.com/opencontainers/runc/libcontainer.(*initProcess).start() /home/kir/go/src/github.com/opencontainers/runc/libcontainer/process_linux.go:313 +0xda github.com/opencontainers/runc/libcontainer.(*linuxContainer).start() /home/kir/go/src/github.com/opencontainers/runc/libcontainer/container_linux.go:366 +0xb0 github.com/opencontainers/runc/libcontainer.(*linuxContainer).Start() /home/kir/go/src/github.com/opencontainers/runc/libcontainer/container_linux.go:263 +0x27b github.com/opencontainers/runc/libcontainer.(*linuxContainer).Run() /home/kir/go/src/github.com/opencontainers/runc/libcontainer/container_linux.go:273 +0x46 github.com/opencontainers/runc/libcontainer/integration.testCheckpoint() /home/kir/go/src/github.com/opencontainers/runc/libcontainer/integration/checkpoint_test.go:108 +0x941 github.com/opencontainers/runc/libcontainer/integration.TestUsernsCheckpoint() /home/kir/go/src/github.com/opencontainers/runc/libcontainer/integration/checkpoint_test.go:48 +0x177 testing.tRunner() /usr/lib/golang/src/testing/testing.go:1123 +0x202 ================== testing.go:1038: race detected during execution of test --- FAIL: TestUsernsCheckpoint (0.62s) Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
251 lines
4.5 KiB
Go
251 lines
4.5 KiB
Go
package integration
|
|
|
|
import (
|
|
"bufio"
|
|
"bytes"
|
|
"io/ioutil"
|
|
"os"
|
|
"os/exec"
|
|
"path/filepath"
|
|
"strings"
|
|
"testing"
|
|
|
|
"github.com/opencontainers/runc/libcontainer"
|
|
)
|
|
|
|
func showFile(t *testing.T, fname string) error {
|
|
t.Logf("=== %s ===\n", fname)
|
|
|
|
f, err := os.Open(fname)
|
|
if err != nil {
|
|
t.Log(err)
|
|
return err
|
|
}
|
|
defer f.Close()
|
|
|
|
scanner := bufio.NewScanner(f)
|
|
for scanner.Scan() {
|
|
t.Log(scanner.Text())
|
|
}
|
|
|
|
if err := scanner.Err(); err != nil {
|
|
return err
|
|
}
|
|
|
|
t.Logf("=== END ===\n")
|
|
|
|
return nil
|
|
}
|
|
|
|
func TestUsernsCheckpoint(t *testing.T) {
|
|
if _, err := os.Stat("/proc/self/ns/user"); os.IsNotExist(err) {
|
|
t.Skip("userns is unsupported")
|
|
}
|
|
cmd := exec.Command("criu", "check", "--feature", "userns")
|
|
if err := cmd.Run(); err != nil {
|
|
t.Skip("Unable to c/r a container with userns")
|
|
}
|
|
testCheckpoint(t, true)
|
|
}
|
|
|
|
func TestCheckpoint(t *testing.T) {
|
|
testCheckpoint(t, false)
|
|
}
|
|
|
|
func testCheckpoint(t *testing.T, userns bool) {
|
|
if testing.Short() {
|
|
return
|
|
}
|
|
|
|
if _, err := exec.LookPath("criu"); err != nil {
|
|
t.Skipf("criu binary not found: %v", err)
|
|
}
|
|
|
|
root, err := newTestRoot()
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
defer os.RemoveAll(root)
|
|
|
|
rootfs, err := newRootfs()
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
defer remove(rootfs)
|
|
|
|
config := newTemplateConfig(&tParam{
|
|
rootfs: rootfs,
|
|
userns: userns,
|
|
})
|
|
factory, err := libcontainer.New(root, libcontainer.Cgroupfs)
|
|
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
container, err := factory.Create("test", config)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
defer container.Destroy()
|
|
|
|
stdinR, stdinW, err := os.Pipe()
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
var stdout bytes.Buffer
|
|
|
|
pconfig := libcontainer.Process{
|
|
Cwd: "/",
|
|
Args: []string{"cat"},
|
|
Env: standardEnvironment,
|
|
Stdin: stdinR,
|
|
Stdout: &stdout,
|
|
Init: true,
|
|
}
|
|
|
|
err = container.Run(&pconfig)
|
|
stdinR.Close()
|
|
defer stdinW.Close()
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
pid, err := pconfig.Pid()
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
process, err := os.FindProcess(pid)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
parentDir, err := ioutil.TempDir("", "criu-parent")
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
defer os.RemoveAll(parentDir)
|
|
|
|
preDumpOpts := &libcontainer.CriuOpts{
|
|
ImagesDirectory: parentDir,
|
|
WorkDirectory: parentDir,
|
|
PreDump: true,
|
|
}
|
|
preDumpLog := filepath.Join(preDumpOpts.WorkDirectory, "dump.log")
|
|
|
|
if err := container.Checkpoint(preDumpOpts); err != nil {
|
|
showFile(t, preDumpLog)
|
|
t.Fatal(err)
|
|
}
|
|
|
|
state, err := container.Status()
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
if state != libcontainer.Running {
|
|
t.Fatal("Unexpected preDump state: ", state)
|
|
}
|
|
|
|
imagesDir, err := ioutil.TempDir("", "criu")
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
defer os.RemoveAll(imagesDir)
|
|
|
|
checkpointOpts := &libcontainer.CriuOpts{
|
|
ImagesDirectory: imagesDir,
|
|
WorkDirectory: imagesDir,
|
|
ParentImage: "../criu-parent",
|
|
}
|
|
dumpLog := filepath.Join(checkpointOpts.WorkDirectory, "dump.log")
|
|
restoreLog := filepath.Join(checkpointOpts.WorkDirectory, "restore.log")
|
|
|
|
if err := container.Checkpoint(checkpointOpts); err != nil {
|
|
showFile(t, dumpLog)
|
|
t.Fatal(err)
|
|
}
|
|
|
|
state, err = container.Status()
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
if state != libcontainer.Stopped {
|
|
t.Fatal("Unexpected state checkpoint: ", state)
|
|
}
|
|
|
|
stdinW.Close()
|
|
_, err = process.Wait()
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
// reload the container
|
|
container, err = factory.Load("test")
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
restoreStdinR, restoreStdinW, err := os.Pipe()
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
var restoreStdout bytes.Buffer
|
|
restoreProcessConfig := &libcontainer.Process{
|
|
Cwd: "/",
|
|
Stdin: restoreStdinR,
|
|
Stdout: &restoreStdout,
|
|
Init: true,
|
|
}
|
|
|
|
err = container.Restore(restoreProcessConfig, checkpointOpts)
|
|
restoreStdinR.Close()
|
|
defer restoreStdinW.Close()
|
|
if err != nil {
|
|
showFile(t, restoreLog)
|
|
t.Fatal(err)
|
|
}
|
|
|
|
state, err = container.Status()
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
if state != libcontainer.Running {
|
|
t.Fatal("Unexpected restore state: ", state)
|
|
}
|
|
|
|
pid, err = restoreProcessConfig.Pid()
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
_, err = os.FindProcess(pid)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
_, err = restoreStdinW.WriteString("Hello!")
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
restoreStdinW.Close()
|
|
s, err := restoreProcessConfig.Wait()
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
if !s.Success() {
|
|
t.Fatal(s.String(), pid)
|
|
}
|
|
|
|
output := restoreStdout.String()
|
|
if !strings.Contains(output, "Hello!") {
|
|
t.Fatal("Did not restore the pipe correctly:", output)
|
|
}
|
|
}
|