rtmp: split net.Conn from rtmp.Conn

go.mod

@@ -5,7 +5,7 @@ go 1.17
 require (
 	code.cloudfoundry.org/bytefmt v0.0.0-20211005130812-5bb3c17173e5
 	github.com/abema/go-mp4 v0.7.2
-	github.com/aler9/gortsplib v0.0.0-20220705212903-df7336b5e81c
+	github.com/aler9/gortsplib v0.0.0-20220709151311-234e4f4f8d6f
 	github.com/asticode/go-astits v1.10.1-0.20220319093903-4abe66a9b757
 	github.com/fsnotify/fsnotify v1.4.9
 	github.com/gin-gonic/gin v1.8.1

go.sum

@@ -6,8 +6,8 @@ github.com/alecthomas/template v0.0.0-20190718012654-fb15b899a751 h1:JYp7IbQjafo
 github.com/alecthomas/template v0.0.0-20190718012654-fb15b899a751/go.mod h1:LOuyumcjzFXgccqObfd/Ljyb9UuFJ6TxHnclSeseNhc=
 github.com/alecthomas/units v0.0.0-20190924025748-f65c72e2690d h1:UQZhZ2O0vMHr2cI+DC1Mbh0TJxzA3RcLoMsFw+aXw7E=
 github.com/alecthomas/units v0.0.0-20190924025748-f65c72e2690d/go.mod h1:rBZYJk541a8SKzHPHnH3zbiI+7dagKZ0cgpgrD7Fyho=
-github.com/aler9/gortsplib v0.0.0-20220705212903-df7336b5e81c h1:aTx9xxf5j00n9iSaEOKrsGc5HKIXogaGEOlmXWkJFww=
+github.com/aler9/gortsplib v0.0.0-20220709151311-234e4f4f8d6f h1:EC+MOSv3e8ZEvtdHoL1++HahNoiVIkvu2Ygjrx6LyOg=
-github.com/aler9/gortsplib v0.0.0-20220705212903-df7336b5e81c/go.mod h1:WI3nMhY2mM6nfoeW9uyk7TyG5Qr6YnYxmFoCply0sbo=
+github.com/aler9/gortsplib v0.0.0-20220709151311-234e4f4f8d6f/go.mod h1:WI3nMhY2mM6nfoeW9uyk7TyG5Qr6YnYxmFoCply0sbo=
 github.com/aler9/rtmp v0.0.0-20210403095203-3be4a5535927 h1:95mXJ5fUCYpBRdSOnLAQAdJHHKxxxJrVCiaqDi965YQ=
 github.com/aler9/rtmp v0.0.0-20210403095203-3be4a5535927/go.mod h1:vzuE21rowz+lT1NGsWbreIvYulgBpCGnQyeTyFblUHc=
 github.com/aler9/writerseeker v0.0.0-20220601075008-6f0e685b9c82 h1:9WgSzBLo3a9ToSVV7sRTBYZ1GGOZUpq4+5H3SN0UZq4=

internal/core/hls_source_test.go

@@ -11,6 +11,7 @@ import (
 
 	"github.com/aler9/gortsplib"
 	"github.com/aler9/gortsplib/pkg/h264"
+	"github.com/aler9/gortsplib/pkg/url"
 	"github.com/asticode/go-astits"
 	"github.com/gin-gonic/gin"
 	"github.com/stretchr/testify/require"
@@ -139,9 +140,18 @@ func TestHLSSource(t *testing.T) {
 		},
 	}
 
-	err = c.StartReading("rtsp://localhost:8554/proxied")
+	u, err := url.Parse("rtsp://localhost:8554/proxied")
+	require.NoError(t, err)
+
+	err = c.Start(u.Scheme, u.Host)
 	require.NoError(t, err)
 	defer c.Close()
 
+	tracks, baseURL, _, err := c.Describe(u)
+	require.NoError(t, err)
+
+	err = c.SetupAndPlay(tracks, baseURL)
+	require.NoError(t, err)
+
 	<-frameRecv
 }

internal/core/rtmp_conn.go

@@ -66,6 +66,7 @@ type rtmpConn struct {
 	runOnConnectRestart       bool
 	wg                        *sync.WaitGroup
 	conn                      *rtmp.Conn
+	nconn                     net.Conn
 	externalCmdPool           *externalcmd.Pool
 	pathManager               rtmpConnPathManager
 	parent                    rtmpConnParent
@@ -107,6 +108,7 @@ func newRTMPConn(
 		runOnConnectRestart:       runOnConnectRestart,
 		wg:                        wg,
 		conn:                      rtmp.NewServerConn(nconn),
+		nconn:                     nconn,
 		externalCmdPool:           externalCmdPool,
 		pathManager:               pathManager,
 		parent:                    parent,
@@ -134,15 +136,15 @@ func (c *rtmpConn) ID() string {
 
 // RemoteAddr returns the remote address of the Conn.
 func (c *rtmpConn) RemoteAddr() net.Addr {
-	return c.conn.RemoteAddr()
+	return c.nconn.RemoteAddr()
 }
 
 func (c *rtmpConn) log(level logger.Level, format string, args ...interface{}) {
-	c.parent.log(level, "[conn %v] "+format, append([]interface{}{c.conn.RemoteAddr()}, args...)...)
+	c.parent.log(level, "[conn %v] "+format, append([]interface{}{c.nconn.RemoteAddr()}, args...)...)
 }
 
 func (c *rtmpConn) ip() net.IP {
-	return c.conn.RemoteAddr().(*net.TCPAddr).IP
+	return c.nconn.RemoteAddr().(*net.TCPAddr).IP
 }
 
 func (c *rtmpConn) safeState() rtmpConnState {
@@ -204,11 +206,11 @@ func (c *rtmpConn) run() {
 func (c *rtmpConn) runInner(ctx context.Context) error {
 	go func() {
 		<-ctx.Done()
-		c.conn.Close()
+		c.nconn.Close()
 	}()
 
-	c.conn.SetReadDeadline(time.Now().Add(time.Duration(c.readTimeout)))
+	c.nconn.SetReadDeadline(time.Now().Add(time.Duration(c.readTimeout)))
-	c.conn.SetWriteDeadline(time.Now().Add(time.Duration(c.writeTimeout)))
+	c.nconn.SetWriteDeadline(time.Now().Add(time.Duration(c.writeTimeout)))
 	err := c.conn.ServerHandshake()
 	if err != nil {
 		return err
@@ -291,7 +293,7 @@ func (c *rtmpConn) runRead(ctx context.Context) error {
 		return fmt.Errorf("the stream doesn't contain an H264 track or an AAC track")
 	}
 
-	c.conn.SetWriteDeadline(time.Now().Add(time.Duration(c.writeTimeout)))
+	c.nconn.SetWriteDeadline(time.Now().Add(time.Duration(c.writeTimeout)))
 	err := c.conn.WriteTracks(videoTrack, audioTrack)
 	if err != nil {
 		return err
@@ -325,7 +327,7 @@ func (c *rtmpConn) runRead(ctx context.Context) error {
 	}
 
 	// disable read deadline
-	c.conn.SetReadDeadline(time.Time{})
+	c.nconn.SetReadDeadline(time.Time{})
 
 	var videoInitialPTS *time.Duration
 	videoFirstIDRFound := false
@@ -435,7 +437,7 @@ func (c *rtmpConn) runRead(ctx context.Context) error {
 				return err
 			}
 
-			c.conn.SetWriteDeadline(time.Now().Add(time.Duration(c.writeTimeout)))
+			c.nconn.SetWriteDeadline(time.Now().Add(time.Duration(c.writeTimeout)))
 			err = c.conn.WritePacket(av.Packet{
 				Type:  av.H264,
 				Data:  avcc,
@@ -464,7 +466,7 @@ func (c *rtmpConn) runRead(ctx context.Context) error {
 			}
 
 			for i, au := range aus {
-				c.conn.SetWriteDeadline(time.Now().Add(time.Duration(c.writeTimeout)))
+				c.nconn.SetWriteDeadline(time.Now().Add(time.Duration(c.writeTimeout)))
 				err := c.conn.WritePacket(av.Packet{
 					Type: av.AAC,
 					Data: au,
@@ -479,7 +481,7 @@ func (c *rtmpConn) runRead(ctx context.Context) error {
 }
 
 func (c *rtmpConn) runPublish(ctx context.Context) error {
-	c.conn.SetReadDeadline(time.Now().Add(time.Duration(c.readTimeout)))
+	c.nconn.SetReadDeadline(time.Now().Add(time.Duration(c.readTimeout)))
 	videoTrack, audioTrack, err := c.conn.ReadTracks()
 	if err != nil {
 		return err
@@ -545,7 +547,7 @@ func (c *rtmpConn) runPublish(ctx context.Context) error {
 	c.stateMutex.Unlock()
 
 	// disable write deadline
-	c.conn.SetWriteDeadline(time.Time{})
+	c.nconn.SetWriteDeadline(time.Time{})
 
 	rres := c.path.onPublisherRecord(pathPublisherRecordReq{
 		author: c,
@@ -556,7 +558,7 @@ func (c *rtmpConn) runPublish(ctx context.Context) error {
 	}
 
 	for {
-		c.conn.SetReadDeadline(time.Now().Add(time.Duration(c.readTimeout)))
+		c.nconn.SetReadDeadline(time.Now().Add(time.Duration(c.readTimeout)))
 		pkt, err := c.conn.ReadPacket()
 		if err != nil {
 			return err

internal/core/rtmp_server_test.go

@@ -1,8 +1,9 @@
 package core
 
 import (
-	"context"
 	"io"
+	"net"
+	"net/url"
 	"testing"
 	"time"
 
@@ -134,10 +135,13 @@ func TestRTMPServerAuth(t *testing.T) {
 				defer a.close()
 			}
 
-			conn, err := rtmp.DialContext(context.Background(),
+			u, err := url.Parse("rtmp://127.0.0.1:1935/teststream?user=testreader&pass=testpass&param=value")
-				"rtmp://127.0.0.1/teststream?user=testreader&pass=testpass&param=value")
 			require.NoError(t, err)
-			defer conn.Close()
+
+			nconn, err := net.Dial("tcp", u.Host)
+			require.NoError(t, err)
+			defer nconn.Close()
+			conn := rtmp.NewClientConn(nconn, u)
 
 			err = conn.ClientHandshake(true)
 			require.NoError(t, err)
@@ -219,9 +223,13 @@ func TestRTMPServerAuthFail(t *testing.T) {
 
 		time.Sleep(1 * time.Second)
 
-		conn, err := rtmp.DialContext(context.Background(), "rtmp://127.0.0.1/teststream?user=testuser&pass=testpass")
+		u, err := url.Parse("rtmp://127.0.0.1:1935/teststream?user=testuser&pass=testpass")
 		require.NoError(t, err)
-		defer conn.Close()
+
+		nconn, err := net.Dial("tcp", u.Host)
+		require.NoError(t, err)
+		defer nconn.Close()
+		conn := rtmp.NewClientConn(nconn, u)
 
 		err = conn.ClientHandshake(true)
 		require.Equal(t, err, io.EOF)

internal/core/rtmp_source.go

@@ -3,6 +3,8 @@ package core
 import (
 	"context"
 	"fmt"
+	"net"
+	"net/url"
 	"sync"
 	"time"
 
@@ -104,26 +106,40 @@ func (s *rtmpSource) runInner() bool {
 		runErr <- func() error {
 			s.log(logger.Debug, "connecting")
 
-			ctx2, cancel2 := context.WithTimeout(innerCtx, time.Duration(s.readTimeout))
+			u, err := url.Parse(s.ur)
-			defer cancel2()
-
-			conn, err := rtmp.DialContext(ctx2, s.ur)
 			if err != nil {
 				return err
 			}
 
+			// add default port
+			_, _, err = net.SplitHostPort(u.Host)
+			if err != nil {
+				u.Host = net.JoinHostPort(u.Host, "1935")
+			}
+
+			ctx2, cancel2 := context.WithTimeout(innerCtx, time.Duration(s.readTimeout))
+			defer cancel2()
+
+			var d net.Dialer
+			nconn, err := d.DialContext(ctx2, "tcp", u.Host)
+			if err != nil {
+				return err
+			}
+
+			conn := rtmp.NewClientConn(nconn, u)
+
 			readDone := make(chan error)
 			go func() {
 				readDone <- func() error {
-					conn.SetReadDeadline(time.Now().Add(time.Duration(s.readTimeout)))
+					nconn.SetReadDeadline(time.Now().Add(time.Duration(s.readTimeout)))
-					conn.SetWriteDeadline(time.Now().Add(time.Duration(s.writeTimeout)))
+					nconn.SetWriteDeadline(time.Now().Add(time.Duration(s.writeTimeout)))
 					err = conn.ClientHandshake(true)
 					if err != nil {
 						return err
 					}
 
-					conn.SetWriteDeadline(time.Time{})
+					nconn.SetWriteDeadline(time.Time{})
-					conn.SetReadDeadline(time.Now().Add(time.Duration(s.readTimeout)))
+					nconn.SetReadDeadline(time.Now().Add(time.Duration(s.readTimeout)))
 					videoTrack, audioTrack, err := conn.ReadTracks()
 					if err != nil {
 						return err
@@ -170,7 +186,7 @@ func (s *rtmpSource) runInner() bool {
 					}()
 
 					for {
-						conn.SetReadDeadline(time.Now().Add(time.Duration(s.readTimeout)))
+						nconn.SetReadDeadline(time.Now().Add(time.Duration(s.readTimeout)))
 						pkt, err := conn.ReadPacket()
 						if err != nil {
 							return err
@@ -237,11 +253,11 @@ func (s *rtmpSource) runInner() bool {
 
 			select {
 			case err := <-readDone:
-				conn.Close()
+				nconn.Close()
 				return err
 
 			case <-innerCtx.Done():
-				conn.Close()
+				nconn.Close()
 				<-readDone
 				return nil
 			}

internal/core/rtsp_server_test.go

@@ -6,6 +6,7 @@ import (
 	"time"
 
 	"github.com/aler9/gortsplib"
+	"github.com/aler9/gortsplib/pkg/url"
 	"github.com/pion/rtp"
 	"github.com/stretchr/testify/require"
 )
@@ -254,9 +255,18 @@ func TestRTSPServerAuth(t *testing.T) {
 
 			reader := gortsplib.Client{}
 
-			err = reader.StartReading("rtsp://testreader:testpass@127.0.0.1:8554/teststream?param=value")
+			u, err := url.Parse("rtsp://testreader:testpass@127.0.0.1:8554/teststream?param=value")
+			require.NoError(t, err)
+
+			err = reader.Start(u.Scheme, u.Host)
 			require.NoError(t, err)
 			defer reader.Close()
+
+			tracks, baseURL, _, err := reader.Describe(u)
+			require.NoError(t, err)
+
+			err = reader.SetupAndPlay(tracks, baseURL)
+			require.NoError(t, err)
 		})
 	}
 
@@ -367,9 +377,14 @@ func TestRTSPServerAuthFail(t *testing.T) {
 
 			c := gortsplib.Client{}
 
-			err := c.StartReading(
+			u, err := url.Parse("rtsp://" + ca.user + ":" + ca.pass + "@localhost:8554/test/stream")
-				"rtsp://" + ca.user + ":" + ca.pass + "@localhost:8554/test/stream",
+			require.NoError(t, err)
-			)
+
+			err = c.Start(u.Scheme, u.Host)
+			require.NoError(t, err)
+			defer c.Close()
+
+			_, _, _, err = c.Describe(u)
 			require.EqualError(t, err, "bad status code: 401 (Unauthorized)")
 		})
 	}
@@ -481,10 +496,19 @@ func TestRTSPServerPublisherOverride(t *testing.T) {
 				},
 			}
 
-			err = c.StartReading("rtsp://localhost:8554/teststream")
+			u, err := url.Parse("rtsp://localhost:8554/teststream")
+			require.NoError(t, err)
+
+			err = c.Start(u.Scheme, u.Host)
 			require.NoError(t, err)
 			defer c.Close()
 
+			tracks, baseURL, _, err := c.Describe(u)
+			require.NoError(t, err)
+
+			err = c.SetupAndPlay(tracks, baseURL)
+			require.NoError(t, err)
+
 			err = s1.WritePacketRTP(0, &rtp.Packet{
 				Header: rtp.Header{
 					Version:        0x02,

internal/core/rtsp_source_test.go

@@ -156,10 +156,19 @@ func TestRTSPSource(t *testing.T) {
 				},
 			}
 
-			err = c.StartReading("rtsp://127.0.0.1:8554/proxied")
+			u, err := url.Parse("rtsp://127.0.0.1:8554/proxied")
+			require.NoError(t, err)
+
+			err = c.Start(u.Scheme, u.Host)
 			require.NoError(t, err)
 			defer c.Close()
 
+			tracks, baseURL, _, err := c.Describe(u)
+			require.NoError(t, err)
+
+			err = c.SetupAndPlay(tracks, baseURL)
+			require.NoError(t, err)
+
 			<-received
 		})
 	}

internal/rtmp/client.go

@@ -1,38 +0,0 @@
-package rtmp
-
-import (
-	"bufio"
-	"context"
-	"net"
-	"net/url"
-
-	"github.com/notedit/rtmp/format/rtmp"
-)
-
-// DialContext connects to a server in reading mode.
-func DialContext(ctx context.Context, address string) (*Conn, error) {
-	// https://github.com/aler9/rtmp/blob/3be4a55359274dcd88762e72aa0a702e2d8ba2fd/format/rtmp/client.go#L74
-
-	u, err := url.Parse(address)
-	if err != nil {
-		return nil, err
-	}
-	host := rtmp.UrlGetHost(u)
-
-	var d net.Dialer
-	nconn, err := d.DialContext(ctx, "tcp", host)
-	if err != nil {
-		return nil, err
-	}
-
-	rconn := rtmp.NewConn(&bufio.ReadWriter{
-		Reader: bufio.NewReaderSize(nconn, readBufferSize),
-		Writer: bufio.NewWriterSize(nconn, writeBufferSize),
-	})
-	rconn.URL = u
-
-	return &Conn{
-		rconn: rconn,
-		nconn: nconn,
-	}, nil
-}

internal/rtmp/conn.go

@@ -1,6 +1,7 @@
 package rtmp
 
 import (
+	"bufio"
 	"errors"
 	"fmt"
 	"net"
@@ -26,12 +27,33 @@ const (
 // Conn is a RTMP connection.
 type Conn struct {
 	rconn *rtmp.Conn
-	nconn net.Conn
 }
 
-// Close closes the connection.
+// NewClientConn initializes a client-side connection.
-func (c *Conn) Close() error {
+func NewClientConn(nconn net.Conn, u *url.URL) *Conn {
-	return c.nconn.Close()
+	c := rtmp.NewConn(&bufio.ReadWriter{
+		Reader: bufio.NewReaderSize(nconn, readBufferSize),
+		Writer: bufio.NewWriterSize(nconn, writeBufferSize),
+	})
+	c.URL = u
+
+	return &Conn{
+		rconn: c,
+	}
+}
+
+// NewServerConn initializes a server-side connection.
+func NewServerConn(nconn net.Conn) *Conn {
+	// https://github.com/aler9/rtmp/blob/master/format/rtmp/server.go#L46
+	c := rtmp.NewConn(&bufio.ReadWriter{
+		Reader: bufio.NewReaderSize(nconn, readBufferSize),
+		Writer: bufio.NewWriterSize(nconn, writeBufferSize),
+	})
+	c.IsServer = true
+
+	return &Conn{
+		rconn: c,
+	}
 }
 
 // ClientHandshake performs the handshake of a client-side connection.
@@ -50,21 +72,6 @@ func (c *Conn) ServerHandshake() error {
 	return c.rconn.Prepare(rtmp.StageGotPublishOrPlayCommand, 0)
 }
 
-// SetReadDeadline sets the read deadline.
-func (c *Conn) SetReadDeadline(t time.Time) error {
-	return c.nconn.SetReadDeadline(t)
-}
-
-// SetWriteDeadline sets the write deadline.
-func (c *Conn) SetWriteDeadline(t time.Time) error {
-	return c.nconn.SetWriteDeadline(t)
-}
-
-// RemoteAddr returns the remote network address.
-func (c *Conn) RemoteAddr() net.Addr {
-	return c.nconn.RemoteAddr()
-}
-
 // IsPublishing returns whether the connection is publishing.
 func (c *Conn) IsPublishing() bool {
 	return c.rconn.Publishing

internal/rtmp/conn_test.go

@@ -1,7 +1,6 @@
 package rtmp
 
 import (
-	"context"
 	"net"
 	"net/url"
 	"strings"
@@ -218,9 +217,13 @@ func TestClientHandshake(t *testing.T) {
 		close(done)
 	}()
 
-	conn, err := DialContext(context.Background(), "rtmp://127.0.0.1:9121/stream")
+	u, err := url.Parse("rtmp://127.0.0.1:9121/stream")
 	require.NoError(t, err)
-	defer conn.Close()
+
+	nconn, err := net.Dial("tcp", u.Host)
+	require.NoError(t, err)
+	defer nconn.Close()
+	conn := NewClientConn(nconn, u)
 
 	err = conn.ClientHandshake(true)
 	require.NoError(t, err)

internal/rtmp/server.go

@@ -1,23 +0,0 @@
-package rtmp
-
-import (
-	"bufio"
-	"net"
-
-	"github.com/notedit/rtmp/format/rtmp"
-)
-
-// NewServerConn initializes a server-side connection.
-func NewServerConn(nconn net.Conn) *Conn {
-	// https://github.com/aler9/rtmp/blob/master/format/rtmp/server.go#L46
-	c := rtmp.NewConn(&bufio.ReadWriter{
-		Reader: bufio.NewReaderSize(nconn, readBufferSize),
-		Writer: bufio.NewWriterSize(nconn, writeBufferSize),
-	})
-	c.IsServer = true
-
-	return &Conn{
-		rconn: c,
-		nconn: nconn,
-	}
-}