rushtehrani
78fde018fd
support resource limits for GPUs in Workflows
2020-12-07 15:51:50 -08:00
Andrey Melnikov
0cf38f8c85
chore: method documentation
2020-11-17 13:49:14 -08:00
Andrey Melnikov
fd713e0800
feat: added update metrics endpoint which replaces the contents. Also renamed merge to add to better distinguish the two
2020-11-17 13:42:19 -08:00
Andrey Melnikov
6af5d5b5b0
feat: added merge method workflow executions merge api
2020-11-17 13:32:55 -08:00
Andrey Melnikov
0a73aed929
feat: updated metrics structure to be an array of structs
2020-11-16 16:04:20 -08:00
Andrey Melnikov
212ef7c0de
feat: added metrics to workflow_executions database related code
2020-11-16 12:08:17 -08:00
Andrey Melnikov
8a9637bc22
fix: add hydrator
2020-11-13 12:06:18 -08:00
Andrey Melnikov
091e1d7c44
chore: removed todo comments that have been resolved
2020-11-13 12:03:53 -08:00
Andrey Melnikov
3ae2dd8077
upgraded argo to v2.11.6 (wip)
2020-11-13 11:59:44 -08:00
Aleksandr Melnikov
b296d85c07
Merge branch 'master' into chore/removing.unused.function
2020-11-13 10:17:35 -08:00
rushtehrani
4fec204e7f
use correct where statement
2020-11-12 12:22:15 -08:00
rushtehrani
f7e48a0be7
don't update phase for already terminated workflow
2020-11-11 09:53:13 -08:00
rushtehrani
3f70f26da4
use stop instead of terminate
2020-11-10 19:38:52 -08:00
Aleksandr Melnikov
f7c74ebf13
Removing ensureWorkflowRunsOnDedicatedNode function.
...
- Not used
- We're using a different function
2020-11-10 16:05:36 -08:00
Aleksandr Melnikov
a5ec80e586
If tty is set to true, mirror the main container volume mounts to
...
sidecars.
- This way, sidecars have access
2020-11-10 15:58:26 -08:00
Aleksandr Melnikov
a67012f893
Tweaking the dependencies of the sys-exit task.
...
- This ensures that multiple sidecars will vertically end
at the sys-exit task.
2020-11-10 15:58:26 -08:00
Aleksandr Melnikov
806d15f4c9
Adjusting the exit-handler task order.
...
- sys-exit will run after deletion of service and virtual service
2020-11-10 15:58:26 -08:00
Aleksandr Melnikov
74752efd20
Adding output parameters to the template with the sidecars.
...
- These are the URLs for the side-cars.
2020-11-10 15:58:26 -08:00
Aleksandr Melnikov
5e4d5c0242
Changed the order of tasks for the exit handler.
...
- The clean up tasks for service(s) and virtualservice(s) will
now display vertically.
If multiple sidecars were present, parallel vertical rows will display.
2020-11-10 15:58:26 -08:00
Aleksandr Melnikov
c699b5b2ba
Changed the order of tasks per feedback.
...
The new structure is:
sys-send-status -> service -> virtual service -> main task
If there are multiple sidecars for the same template, they
are displayed next to each other, vertically and in parallel.
2020-11-10 15:58:26 -08:00
Aleksandr Melnikov
5bd7f222cd
Removing the workflow.uid, because it causes a doubly long uid string.
2020-11-10 15:58:26 -08:00
Aleksandr Melnikov
04a1db0f81
Adding "sys-" prefix to onepanel injected services and virtualservices.
2020-11-10 15:58:26 -08:00
Aleksandr Melnikov
d4846b521e
Putting the services and virtualservices for sidecars logic, into
...
it's own function.
2020-11-10 15:58:26 -08:00
Aleksandr Melnikov
544991117c
Changing the label that maps between the service and pod.
...
- For multiple sidecars, this needs to be unique as well.
2020-11-10 15:58:26 -08:00
Aleksandr Melnikov
8057098e29
Fixing envoyfilter by adding "--" to the sub-domain url that gets
...
generate.d
2020-11-10 15:58:26 -08:00
Aleksandr Melnikov
ccb991207b
Adding code to clean-up the service and virtualservice after the
...
workflow is finished.
- Adding clean-up code to run alongside any onExit tasks.
2020-11-10 15:58:26 -08:00
Aleksandr Melnikov
70007d6d23
Codacy: Fixing variable names.
2020-11-10 15:58:26 -08:00
Aleksandr Melnikov
af47ffbd2f
Updating logic that checks if a sidecar needs routing and service.
...
- Check if tty is set to true on the sidecar.
- Updated formatting.
2020-11-10 15:58:26 -08:00
Aleksandr Melnikov
d8101bff8e
Checking for istio injection by checking if the sidecar has "tty"
...
set to true.
2020-11-10 15:58:26 -08:00
Aleksandr Melnikov
e1c3dc3979
Enabling Istio for workflows with sidecars.
...
- WIP
2020-11-10 15:58:26 -08:00
Aleksandr Melnikov
7698b705d8
Removing unused code.
2020-11-10 15:58:26 -08:00
Aleksandr Melnikov
7b7142da49
Generating names using uuid.
...
- workflow.name is assigned at run-time, and may not be DNS compliant
for a service name. So that variable is not used.
2020-11-10 15:58:26 -08:00
Aleksandr Melnikov
d903baea00
Adding uuid generating library
2020-11-10 15:58:26 -08:00
Aleksandr Melnikov
530e24180d
Simplifying prefix to "/"
2020-11-10 15:58:26 -08:00
Aleksandr Melnikov
f5fb44c59b
Port and TargetPort are assumed to be the same.
...
If Tensorboard has 6006 set, we also set it to 6006.
2020-11-10 15:58:26 -08:00
Aleksandr Melnikov
6d42a44957
Removing condition tests.
2020-11-10 15:58:26 -08:00
Aleksandr Melnikov
2fef7d78c1
Fixing typo.
2020-11-10 15:58:26 -08:00
Aleksandr Melnikov
b46e7fd3b9
Excluding istio side-car from resource creation.
...
- Otherwise, the step hangs and never finishes, so long as istio
container runs.
2020-11-10 15:58:26 -08:00
Aleksandr Melnikov
e5f2f3e937
Adding k8s-service-resource and k8s-routes-resource as tasks
...
and dependencies to the entry point template.
- Issue: Argo throws this error
Message: invalid spec: templates.main.tasks.train-model.dependencies[1] dependency 'k8s-service-resource' not defined
2020-11-10 15:58:26 -08:00
Aleksandr Melnikov
af361d5045
Renaming the side-car check per feedback.
2020-11-10 15:58:26 -08:00
Aleksandr Melnikov
3e1a4dd313
Refactoring code since it's empty initialization.
2020-11-10 15:58:26 -08:00
Aleksandr Melnikov
d2dfd4cc34
Updating the host placeholder.
2020-11-10 15:58:26 -08:00
Aleksandr Melnikov
2d45b0a015
Using the right yaml library to marshal.
2020-11-10 15:58:26 -08:00
Aleksandr Melnikov
cb7bb793e7
Adding code to support sidecars and accessing them.
...
- Specifically, if a sidecar is labeled with "sys-tensorboard-like",
code attempts to create services and virtual services (routes).
- Code will create argo templates that are resource type, where the
manifests are the generated resources.
The templates are then added right before the template with the
sidecar that requires these services and routes.
2020-11-10 15:58:26 -08:00
rushtehrani
875097fed7
only inject one sys-send-status task
2020-11-06 17:35:55 -08:00
Andrey Melnikov
7129fdf55f
fix: issue where s3 with gcs wasn't working because of incompatible listing of files.
2020-10-16 16:41:49 -07:00
Andrey Melnikov
20c4950b69
feat: revert jwt token from auth
2020-10-14 11:53:05 -07:00
Aleksandr Melnikov
83a2543b13
Updating function name to reflect what it's doing.
2020-10-05 14:04:32 -07:00
Aleksandr Melnikov
e8dae0f2e9
Since we're no longer relying on running nodes, we don't need logic
...
relating to them.
- We can just check if a nodeSelector is set on the template.
2020-10-05 13:59:14 -07:00
Aleksandr Melnikov
7fe0ab2654
Tweaking names so it's more clear why they are there.
2020-10-05 11:51:04 -07:00