rushtehrani
e22056876e
add new error type and override workspace template validation messages
2020-06-23 17:42:51 -07:00
rushtehrani
b7bd16610c
fix: show correct parameter error for workspace templates
2020-06-23 17:00:14 -07:00
Andrey Melnikov
8cf8436afc
fix: issue where archiving workspace template was breaking because it attempted to do so for every version, but there was no logical difference since it used the template
2020-06-22 12:11:55 -07:00
Andrey Melnikov
a0197e0883
fix: issue where workspace template versions did not correctly mark latest as latest
2020-06-22 11:32:18 -07:00
rushtehrani
c56a1c0e96
inject runtime params into Argo workflow as well
2020-06-21 11:08:45 -07:00
rushtehrani
441722a8ba
runtime params with only arguments.parameters changes
2020-06-21 01:03:41 -07:00
rushtehrani
ec32dc825c
fix nodepool issue
2020-06-20 13:18:52 -07:00
Andrey Melnikov
d209423100
clean:
...
* updated method names to fit go conventions of uppercase. Db -> DB
* updated some method calls to use updated column select functions to remove extraneous empty string
* updated methods to use new label function that does nothing if no labels are passed in, this simplifies the code.
* updated some methods to use new Selectx function, reducing code in caller.
2020-06-20 13:18:52 -07:00
rushtehrani
ec2ad1a9be
fix param
2020-06-18 19:35:35 -07:00
rushtehrani
640d4f6e9f
add Workspace CRD auth check and creation
2020-06-18 19:35:35 -07:00
Rush Tehrani
7ddd6873ea
Merge branch 'feat/onepanelio.core-348.system.updates' into fix/params
2020-06-17 17:27:47 -07:00
Andrey Melnikov
b6c67dd774
fix: added missing volume
2020-06-17 12:58:59 -07:00
rushtehrani
504c4bf597
workspaceSpec => spec
2020-06-16 21:32:56 -07:00
rushtehrani
f19d3b4e53
allow user to use {{workspace.parameters}} in workspace template
2020-06-16 21:26:14 -07:00
Andrey Melnikov
56777b48c3
fix: parameter name
2020-06-16 10:47:48 -07:00
Andrey Melnikov
3074622046
Merge branch 'dev' into feat/onepanelio.core-348.system.updates
2020-06-16 10:46:27 -07:00
Andrey Melnikov
ba72b1435f
clean: code cleanup and minor documentation
2020-06-16 10:30:37 -07:00
Andrey Melnikov
d56b728995
update: added logic to inject runtime variables in Workspace templates
2020-06-15 18:42:47 -07:00
rushtehrani
814b289024
fix shared memory issues in Workspaces
2020-06-12 18:55:21 -07:00
rushtehrani
5b69516867
skip parameters for volumes that have storage set
2020-06-11 22:23:39 -07:00
rushtehrani
0c28cc1576
rename field
2020-06-11 21:06:10 -07:00
rushtehrani
7cddeb9311
feat: Custom volume claim templates
2020-06-11 20:59:29 -07:00
rushtehrani
6834f660d7
fix: use correct method name
2020-06-04 10:00:56 -07:00
Rush Tehrani
a47bbe949b
Merge pull request #286 from onepanelio/feat/add.cvat.migration.template
...
feat: add cvat migration template
2020-06-04 09:51:02 -07:00
Aleksandr Melnikov
ff7aa917f7
Removing column that does not exist.
2020-06-03 16:57:22 -07:00
Aleksandr Melnikov
8b26a84162
Updated ArchiveWorkspaceTemplate.
...
- Fixed various error message responses
- Added code to grab the WorkspaceTemplate versions
Then, code will run through these versions and grab workspaces that use
that version.
Then, code will try to Archive those workspaces (delete k8s resources,
archive database entries).
Finally, code cleans up the related WorkflowTemplate.
- Updated method docs
2020-06-03 12:46:33 -07:00
rushtehrani
6460fefbd8
append user defined parameters after sys params
2020-06-02 22:31:52 -07:00
Aleksandr Melnikov
1055b228a1
Re-arranged the code that archives the workspace template.
...
- This code was re-arranged to focus on archiving the k8s components
first, then the database.
- Also, workspace components are archived first,
because they rely on the workflow templates being present.
If workflow template is archived first, then the clean-up
can't resume to run again if some error is thrown.
This arrangement will ensure that if an error occurs during clean-up,
it can be re-run without throwing an error of missing prerequisite data.
- Removed an early return statement, which prevented the rest
of the clean-up
- Added extra code to not return an error if no workflow templates
are found in the database. This is to ensure k8s cleanup can continue.
2020-06-02 17:09:54 -07:00
Aleksandr Melnikov
1390d4d235
Updating error reporting to always return the source error.
...
- If extra errors, add them as text.
2020-06-02 16:18:55 -07:00
Aleksandr Melnikov
bf37713371
Migration fails silently because the insert statement lacked "uid" value.
2020-06-02 16:18:37 -07:00
Aleksandr Melnikov
35aef3819f
Changing migrations to use ArchiveWorkspaceTemplate.
...
Ref: https://github.com/onepanelio/core/pull/286#discussion_r432901056
2020-06-01 10:59:47 -07:00
rushtehrani
7911ff02cc
check successCondition of statefulset at creation time as well
2020-05-31 23:27:40 -07:00
rushtehrani
f1ecb595b4
fixes workspace update success condition
2020-05-31 22:47:17 -07:00
Rush Tehrani
67f4634ae0
Merge pull request #284 from onepanelio/fix/onepanelio.core.264-post.execution.workflow.optional
...
fix: added a default post execution workflow if there wasn't one alre…
2020-05-29 10:05:38 -07:00
Andrey Melnikov
271b1ed563
update: removed default PostExecution and only add the post execution if it exists in the setup
2020-05-28 16:53:16 -07:00
Andrey Melnikov
ca1c672f0d
fix: added a default post execution workflow if there wasn't one already.
2020-05-28 13:26:15 -07:00
Andrey Melnikov
b41ddcdc2c
fix: set workspaces dags to be FailFast: false so that even if another part of the dag fails, the sys-exit will not.
2020-05-28 12:28:51 -07:00
rushtehrani
076078601d
only allow workspace templates to be deleted if workspace is terminated
2020-05-22 19:52:41 -07:00
Rush Tehrani
5f697b22f9
Merge pull request #242 from onepanelio/fix/increase-uid-size
...
increase column size to 63 for cron workflows and workflow executions
2020-05-22 17:55:54 -07:00
rushtehrani
3ebd7ab245
increase column size to 63 for cron workflows and workflo executions
2020-05-22 17:26:58 -07:00
Andrey Melnikov
0eaa2b5ea2
fix: added is_archived = false to getting a workspace template, otherwise we get non-archived versions and a crash.
2020-05-22 16:44:47 -07:00
Andrey Melnikov
6bc28c4e72
fix: getting workspace template by name ignores archived ones
2020-05-22 16:27:35 -07:00
Andrey Melnikov
2bc8f684c7
refactored workspace template archive changes.
2020-05-22 16:07:50 -07:00
Andrey Melnikov
1daca92c3e
Merge pull request #215 from onepanelio/feat/archive.workspace.templates
...
Feat/archive.workspace.templates
2020-05-20 13:36:01 -07:00
Andrey Melnikov
d4f849073c
fix: added more detailed error message for 409 workspace template to distinguish between archived workspace taking the name, or another template.
...
Also changed IsArchived to be a bool type instead of string for workspace template type, as that's what it is in the database.
2020-05-20 12:29:28 -07:00
Andrey Melnikov
e0096f9be6
documentation: for ArchiveWorkspaceTemplate
2020-05-19 13:57:44 -07:00
Andrey Melnikov
4f8a92c7a4
fix: added case where a workspace is terminating - a workspace can be archived if all of it's workspaces are terminating.
2020-05-19 13:54:01 -07:00
Andrey Melnikov
21baabd634
update: check if workspace template has running workspaces before archiving it.
2020-05-19 13:47:38 -07:00
Andrey Melnikov
9deee0cc8c
Merge pull request #213 from onepanelio/feat/resource-env-vars
...
feat: resource env vars
2020-05-19 12:43:55 -07:00
Andrey Melnikov
2c9dbf52b3
feature: Added ArchiveWorkspaceTemplate endpoint.
...
update: listing workspace templates ignores archived ones now.
2020-05-19 11:27:19 -07:00
