zishuo/onepanel
1
0
Fork 0
mirror of https://github.com/onepanelio/onepanel.git synced 2025-10-05 13:46:51 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

DRY Principle - Simplified if-else for insert SQL.

Browse Source
This commit is contained in:
Aleksandr Melnikov
2020-04-16 15:48:54 -07:00
parent ad36870b28
commit bcfa8d986d
1 changed files with 20 additions and 31 deletions
Download Patch File Download Diff File Expand all files Collapse all files

51
pkg/workflow_execution.go
View File

@@ -378,41 +378,30 @@ func (c *Client) AddWorkflowExecutionStatistic(namespace, name string, workflowT
return err
}
defer tx.Rollback()
insertMap := sq.Eq{
"workflow_template_id": workflowTemplateID,
"name": name,
"namespace": namespace,
"created_at": createdAt.UTC(),
}
if workflowOutcomeIsSuccess {
_, err := sb.Insert("workflow_executions").
SetMap(sq.Eq{
"workflow_template_id": workflowTemplateID,
"name": name,
"namespace": namespace,
"created_at": createdAt.UTC(),
"finished_at": time.Now().UTC(),
}).RunWith(tx).Exec()
if err != nil {
return err
}
err = tx.Commit()
if err != nil {
return err
}
return err
insertMap["finished_at"] = time.Now().UTC()
} else {
_, err := sb.Insert("workflow_executions").
SetMap(sq.Eq{
"workflow_template_id": workflowTemplateID,
"name": name,
"namespace": namespace,
"created_at": createdAt.UTC(),
"failed_at": time.Now().UTC(),
}).RunWith(tx).Exec()
if err != nil {
return err
}
err = tx.Commit()
if err != nil {
return err
}
insertMap["failed_at"] = time.Now().UTC()
}
_, err = sb.Insert("workflow_executions").
SetMap(insertMap).RunWith(tx).Exec()
if err != nil {
return err
}
err = tx.Commit()
if err != nil {
return err
}
return err
}
func (c *Client) GetWorkflowExecution(namespace, name string) (workflow *WorkflowExecution, err error) {