zishuo/onepanel
1
0
Fork 0
mirror of https://github.com/onepanelio/onepanel.git synced 2025-10-05 13:46:51 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

remove length check since range will not iterate on 0 length slices

Browse Source
This commit is contained in:
rushtehrani
2020-05-19 12:31:15 -07:00
parent 679d7e50b5
commit ac8c622769
1 changed files with 6 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
pkg/workflow_execution.go
View File

@@ -163,21 +163,17 @@ func (c *Client) injectAutomatedFields(namespace string, wf *wfv1.Workflow, opts
}) })
// Extend artifact credentials if only key is provided // Extend artifact credentials if only key is provided
if len(template.Outputs.Artifacts) > 0 {
for j, artifact := range template.Outputs.Artifacts { for j, artifact := range template.Outputs.Artifacts {
if appendArtifactRepositoryConfigIfMissing(&artifact, namespaceConfig) { if appendArtifactRepositoryConfigIfMissing(&artifact, namespaceConfig) {
wf.Spec.Templates[i].Outputs.Artifacts[j] = artifact wf.Spec.Templates[i].Outputs.Artifacts[j] = artifact
} }
} }
}
if len(template.Inputs.Artifacts) > 0 {
for j, artifact := range template.Inputs.Artifacts { for j, artifact := range template.Inputs.Artifacts {
if appendArtifactRepositoryConfigIfMissing(&artifact, namespaceConfig) { if appendArtifactRepositoryConfigIfMissing(&artifact, namespaceConfig) {
wf.Spec.Templates[i].Inputs.Artifacts[j] = artifact wf.Spec.Templates[i].Inputs.Artifacts[j] = artifact
} }
} }
}
//Generate ENV vars from secret, if there is a container present in the workflow //Generate ENV vars from secret, if there is a container present in the workflow
//Get template ENV vars, avoid over-writing them with secret values //Get template ENV vars, avoid over-writing them with secret values