From 767643a51a02780d7c9bbc49e8e43f2e16e5856c Mon Sep 17 00:00:00 2001 From: Andrey Melnikov Date: Tue, 15 Sep 2020 13:59:05 -0700 Subject: [PATCH] fix: issue where omitted visibility is now public and not empty for manifest parameters --- pkg/common_types_test.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pkg/common_types_test.go b/pkg/common_types_test.go index 64a262a..f277a5a 100644 --- a/pkg/common_types_test.go +++ b/pkg/common_types_test.go @@ -48,8 +48,8 @@ func TestParseParametersFromManifest(t *testing.T) { // Make sure visibility is set assert.Equal(t, *keyedParameters["dataset-path"].Visibility, "public") - // Make sure visibility is not set if omitted - assert.Nil(t, keyedParameters["tf-image"].Visibility) + // Make sure visibility is public if omitted + assert.Equal(t, *keyedParameters["tf-image"].Visibility, "public") // Make sure numbers, slashes, dashes, and letters are parsed correctly assert.Equal(t, *keyedParameters["tf-image"].Value, "tensorflow/tensorflow:1.13.1-py3")