From c3335aae28cbf4d2fb5e8c5e82b9a703bd871d9f Mon Sep 17 00:00:00 2001 From: Brian Cunnie Date: Sat, 26 Nov 2022 11:38:56 -0800 Subject: [PATCH] =?UTF-8?q?DNS=20server=20Dockerfile:=20CMD=20=E2=86=92=20?= =?UTF-8?q?ENTRYPOINT?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit `ENTRYPOINT` [is more appropriate](https://codewithyury.com/docker-run-vs-cmd-vs-entrypoint/): > ENTRYPOINT configures a container that will run as an executable Which is exactly how I think the container should work for new people. Yes, I'm screwing over the existing users. Sorry. --- README.md | 1 - k8s/Dockerfile-sslip.io-dns-server | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/README.md b/README.md index 8cf7724..26e2ffb 100644 --- a/README.md +++ b/README.md @@ -93,7 +93,6 @@ docker run \ --rm \ -p 53:53/udp \ cunnie/sslip.io-dns-server \ - /usr/sbin/sslip.io-dns-server \ -nameservers jammy.nono.io \ -addresses jammy.nono.io=10.9.9.114,jammy.nono.io=2601:646:100:69f0:0:ff:fe00:72 ``` diff --git a/k8s/Dockerfile-sslip.io-dns-server b/k8s/Dockerfile-sslip.io-dns-server index fc24ec7..6e11b86 100644 --- a/k8s/Dockerfile-sslip.io-dns-server +++ b/k8s/Dockerfile-sslip.io-dns-server @@ -30,7 +30,7 @@ RUN curl -L https://github.com/cunnie/sslip.io/releases/download/2.6.1/sslip.io- -o /usr/sbin/sslip.io-dns-server; \ chmod 755 /usr/sbin/sslip.io-dns-server -CMD ["/usr/sbin/sslip.io-dns-server"] +ENTRYPOINT ["/usr/sbin/sslip.io-dns-server"] # DNS listens on port 53 UDP # The `EXPOSE` directive doesn't do much in our case. We use it for documentation.