zishuo/nip
1
0
Fork 0
mirror of https://github.com/cunnie/sslip.io.git synced 2025-10-07 00:23:44 +08:00
Code Issues Actions 2 Packages Projects Releases Wiki Activity

PTR for IPv4 is hyphen-, not dot-, separated

Browse Source 
I prefer "192-168-0-1.sslip.io" over "192.168.0.1.sslip.io". It's
marginally faster, and it follows the convention set for IPv6 addrs.
This commit is contained in:
Brian Cunnie
2022-07-12 06:30:01 -07:00
parent 9454203f16
commit 57976fcfb5
2 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/sslip.io-dns-server/integration_test.go
View File

@@ -173,10 +173,10 @@ var _ = Describe("sslip.io-dns-server", func() {
"@127.0.0.1 get._acme-challenge.a.b.c.subdomain-key.k-v.io txt +short", "@127.0.0.1 get._acme-challenge.a.b.c.subdomain-key.k-v.io txt +short",
`baffled-boy._acme-challenge`, `baffled-boy._acme-challenge`,
`TypeTXT get._acme-challenge.a.b.c.subdomain-key.k-v.io. \? \["baffled-boy._acme-challenge"\]`), `TypeTXT get._acme-challenge.a.b.c.subdomain-key.k-v.io. \? \["baffled-boy._acme-challenge"\]`),
Entry(`get a PTR for 1.0.168.192.in-addr.arpa returns 192.168.0.1.sslip.io`, Entry(`get a PTR for 1.0.168.192.in-addr.arpa returns 192-168-0-1.sslip.io`,
"@127.0.0.1 1.0.168.192.in-addr.arpa ptr +short", "@127.0.0.1 1.0.168.192.in-addr.arpa ptr +short",
`\A192.168.0.1.sslip.io.\n\z`, `\A192-168-0-1.sslip.io.\n\z`,
`TypePTR 1.0.168.192.in-addr.arpa. \? 192.168.0.1.sslip.io.`), `TypePTR 1.0.168.192.in-addr.arpa. \? 192-168-0-1.sslip.io.`),
Entry(`get a PTR for 1.0.0.127.blah.in-addr.arpa returns no records`, Entry(`get a PTR for 1.0.0.127.blah.in-addr.arpa returns no records`,
"@127.0.0.1 1.0.0.127.blah.in-addr.arpa ptr +short", "@127.0.0.1 1.0.0.127.blah.in-addr.arpa ptr +short",
`\A\z`, `\A\z`,

2
src/sslip.io-dns-server/xip/xip.go
View File

@@ -856,7 +856,7 @@ func (x *Xip) PTRResource(fqdn []byte) *dnsmessage.PTRResource {
reversedIPv4address[1], reversedIPv4address[1],
reversedIPv4address[0], reversedIPv4address[0],
}) })
ptrName, err := dnsmessage.NewName(ip.String() + ".sslip.io.") ptrName, err := dnsmessage.NewName(strings.ReplaceAll(ip.String(), ".", "-") + ".sslip.io.")
if err != nil { if err != nil {
return nil return nil
} }