From 45d0e586799cf54100058050a04b058cc93809ee Mon Sep 17 00:00:00 2001 From: Brian Cunnie Date: Fri, 2 Sep 2016 13:07:42 -0700 Subject: [PATCH] Don't blindly succeed even when you fail - must use a non-zero exit code to signify failure to Concourse --- ci/tasks/check-dns.rb | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/ci/tasks/check-dns.rb b/ci/tasks/check-dns.rb index a29ebcc..86479b6 100755 --- a/ci/tasks/check-dns.rb +++ b/ci/tasks/check-dns.rb @@ -16,6 +16,8 @@ def get_whois_nameservers(domain) nameservers end +exit_code=0 # assume successful exit + check_domain(domain) puts "[PASS] #{domain} basic check ('DOMAIN' variable set & not empty)" @@ -30,6 +32,9 @@ whois_nameservers.each do |whois_nameserver| puts "[PASS] #{whois_nameserver}'s NS records match whois" else puts "[FAIL] #{whois_nameserver}'s NS records do NOT match whois: #{dig_nameservers.join(", ")}" + exit_code=5 end #p "#{whois_nameserver}: #{nameservers}" end + +exit(exit_code)