zishuo/netmaker
1
0
Fork 0
mirror of https://github.com/gravitl/netmaker.git synced 2025-10-07 09:41:37 +08:00
Code Issues Packages Projects Releases Wiki Activity

Prevent removing idp integration when oauth user is superadmin (#3589)

Browse Source 
* feat(go): prevent removing idp integration when oauth user is superadmin.

* feat(go): add suggestion for user;

* feat(go): remove usages of boolean fields on user;

* feat(go): set boolean fields correctly, but don't use;

* fix(go): static issues;

* feat(go): add suggestion for user;
This commit is contained in:
Vishal Dalwadi
2025-08-25 10:28:53 +05:30
committed by GitHub
parent c3498004c1
commit ec6e6c393a
7 changed files with 53 additions and 27 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
controllers/server.go
View File

@@ -4,6 +4,7 @@ import (
"context"
"encoding/json"
"errors"
"fmt"
"github.com/gravitl/netmaker/db"
"github.com/gravitl/netmaker/schema"
"github.com/google/go-cmp/cmp"
@@ -274,6 +275,24 @@ func updateSettings(w http.ResponseWriter, r *http.Request) {
return
}
currSettings := logic.GetServerSettings()
if req.AuthProvider != currSettings.AuthProvider && req.AuthProvider == "" {
superAdmin, err := logic.GetSuperAdmin()
if err != nil {
err = fmt.Errorf("failed to get super admin: %v", err)
logic.ReturnErrorResponse(w, r, logic.FormatError(err, "internal"))
return
}
if superAdmin.AuthType == models.OAuth {
err := fmt.Errorf(
"cannot remove IdP integration because an OAuth user has the super-admin role; transfer the super-admin role to another user first",
)
logic.ReturnErrorResponse(w, r, logic.FormatError(err, "badrequest"))
return
}
}
err := logic.UpsertServerSettings(req)
if err != nil {
logic.ReturnErrorResponse(w, r, logic.FormatError(errors.New("failed to update server settings "+err.Error()), "internal"))