bug squashin

controllers/common.go

@@ -20,7 +20,11 @@ func GetPeersList(networkName string) ([]models.Node, error) {
 	var peers []models.Node
 	collection, err := database.FetchRecords(database.NODES_TABLE_NAME)
 	if err != nil {
+		if database.IsEmptyRecord(err) {
+			return peers, nil
+		}
 		log.Println(err)
+		return nil, err
 	}
 	udppeers, errN := database.GetPeers(networkName)
 	if errN != nil {

controllers/nodeGrpcController.go

@@ -5,6 +5,7 @@ import (
 	"encoding/json"
 	"errors"
 	"log"
+	"strings"
 
 	"github.com/gravitl/netmaker/functions"
 	nodepb "github.com/gravitl/netmaker/grpc"
@@ -130,12 +131,9 @@ func (s *NodeServiceServer) DeleteNode(ctx context.Context, req *nodepb.Object)
 }
 
 func (s *NodeServiceServer) GetPeers(ctx context.Context, req *nodepb.Object) (*nodepb.Object, error) {
-	var node models.Node
-	if err := json.Unmarshal([]byte(req.GetData()), &node); err != nil {
-		return nil, err
-	}
-
-	peers, err := GetPeersList(node.Network)
+	macAndNetwork := strings.Split(req.Data, "###")
+	if len(macAndNetwork) == 2 {
+		peers, err := GetPeersList(macAndNetwork[1])
 		if err != nil {
 			return nil, err
 		}
@@ -144,7 +142,12 @@ func (s *NodeServiceServer) GetPeers(ctx context.Context, req *nodepb.Object) (*
 		return &nodepb.Object{
 			Data: string(peersData),
 			Type: nodepb.NODE_TYPE,
-	}, nil
+		}, err
+	}
+	return &nodepb.Object{
+		Data: "",
+		Type: nodepb.NODE_TYPE,
+	}, errors.New("could not fetch peers, invalid node id")
 }
 
 /**

database/statics.go

@@ -19,7 +19,7 @@ func SetPeers(newPeers map[string]string, networkName string) bool {
 }
 func GetPeers(networkName string) (map[string]string, error) {
 	record, err := FetchRecord(PEERS_TABLE_NAME, networkName)
-	if err != nil {
+	if err != nil && !IsEmptyRecord(err) {
 		return nil, err
 	}
 	currentDataMap := make(map[string]string)