fixed common tests

This commit is contained in:
Matthew R Kasun
2021-09-08 13:47:45 -04:00
parent 6c36b542b2
commit 977da36673
3 changed files with 123 additions and 197 deletions

View File

@@ -274,28 +274,3 @@ func SetNetworkNodesLastModified(networkName string) error {
}
return nil
}
func TimestampNode(node models.Node, updatecheckin bool, updatepeers bool, updatelm bool) error {
if updatelm {
node.SetLastModified()
}
if updatecheckin {
node.SetLastCheckIn()
}
if updatepeers {
node.SetLastPeerUpdate()
}
key, err := functions.GetRecordKey(node.MacAddress, node.Network)
if err != nil {
return err
}
value, err := json.Marshal(&node)
if err != nil {
return err
}
err = database.Insert(key, string(value), database.NODES_TABLE_NAME)
return err
}

123
controllers/common_test.go Normal file
View File

@@ -0,0 +1,123 @@
package controller
import (
"testing"
"github.com/gravitl/netmaker/database"
"github.com/gravitl/netmaker/models"
"github.com/stretchr/testify/assert"
)
func TestGetPeerList(t *testing.T) {
database.InitializeDatabase()
deleteAllNetworks()
createNet()
t.Run("NoNodes", func(t *testing.T) {
peers, err := GetPeersList("skynet")
assert.Nil(t, err)
assert.Nil(t, peers)
})
node := createTestNode()
t.Run("One Node", func(t *testing.T) {
peers, err := GetPeersList("skynet")
assert.Nil(t, err)
assert.Equal(t, node.Address, peers[0].Address)
})
t.Run("Multiple Nodes", func(t *testing.T) {
createnode := models.Node{PublicKey: "RM5qhLAE20PG9BbfBCger+Ac9D2NDOwCtY1rbYDLf34=", Endpoint: "10.0.0.2", MacAddress: "02:02:03:04:05:06", Password: "password", Network: "skynet"}
CreateNode(createnode, "skynet")
peers, err := GetPeersList("skynet")
assert.Nil(t, err)
assert.Equal(t, node.Endpoint, peers[0].Endpoint)
assert.Equal(t, createnode.Endpoint, peers[1].Endpoint)
})
}
func TestDeleteNode(t *testing.T) {
database.InitializeDatabase()
deleteAllNetworks()
createNet()
node := createTestNode()
t.Run("NodeExists", func(t *testing.T) {
err := DeleteNode(node.MacAddress, true)
assert.Nil(t, err)
})
t.Run("NonExistantNode", func(t *testing.T) {
err := DeleteNode(node.MacAddress, true)
assert.Nil(t, err)
})
}
func TestGetNode(t *testing.T) {
database.InitializeDatabase()
deleteAllNetworks()
t.Run("NoNode", func(t *testing.T) {
response, err := GetNode("01:02:03:04:05:06", "skynet")
assert.Equal(t, models.Node{}, response)
assert.EqualError(t, err, "unexpected end of JSON input")
})
createNet()
node := createTestNode()
t.Run("NodeExists", func(t *testing.T) {
response, err := GetNode(node.MacAddress, node.Network)
assert.Nil(t, err)
assert.Equal(t, "10.0.0.1", response.Endpoint)
assert.Equal(t, "DM5qhLAE20PG9BbfBCger+Ac9D2NDOwCtY1rbYDLf34=", response.PublicKey)
assert.Equal(t, "01:02:03:04:05:06", response.MacAddress)
assert.Equal(t, int32(51821), response.ListenPort)
assert.NotNil(t, response.Name)
assert.Equal(t, "skynet", response.Network)
assert.Equal(t, "nm-skynet", response.Interface)
})
t.Run("BadMac", func(t *testing.T) {
response, err := GetNode("01:02:03:04:05:07", node.Network)
assert.Equal(t, models.Node{}, response)
assert.EqualError(t, err, "unexpected end of JSON input")
})
t.Run("BadNetwork", func(t *testing.T) {
response, err := GetNode(node.MacAddress, "badnet")
assert.Equal(t, models.Node{}, response)
assert.EqualError(t, err, "unexpected end of JSON input")
})
}
func TestCreateNode(t *testing.T) {
t.Skip()
database.InitializeDatabase()
deleteAllNetworks()
createNet()
createnode := models.Node{PublicKey: "DM5qhLAE20PG9BbfBCger+Ac9D2NDOwCtY1rbYDLf34=", Endpoint: "10.0.0.1", MacAddress: "01:02:03:04:05:06", Password: "password", Network: "skynet"}
//err := ValidateNodeCreate("skynet", createnode)
//assert.Nil(t, err)
node, err := CreateNode(createnode, "skynet")
assert.Nil(t, err)
assert.Equal(t, "10.0.0.1", node.Endpoint)
assert.Equal(t, "DM5qhLAE20PG9BbfBCger+Ac9D2NDOwCtY1rbYDLf34=", node.PublicKey)
assert.Equal(t, "01:02:03:04:05:06", node.MacAddress)
assert.Equal(t, int32(51821), node.ListenPort)
assert.NotNil(t, node.Name)
assert.Equal(t, "skynet", node.Network)
assert.Equal(t, "nm-skynet", node.Interface)
}
func TestSetNetworkNodesLastModified(t *testing.T) {
database.InitializeDatabase()
deleteAllNetworks()
createNet()
t.Run("InvalidNetwork", func(t *testing.T) {
err := SetNetworkNodesLastModified("badnet")
assert.EqualError(t, err, "no result found")
})
t.Run("NetworkExists", func(t *testing.T) {
err := SetNetworkNodesLastModified("skynet")
assert.Nil(t, err)
})
}
func createTestNode() models.Node {
createnode := models.Node{PublicKey: "DM5qhLAE20PG9BbfBCger+Ac9D2NDOwCtY1rbYDLf34=", Endpoint: "10.0.0.1", MacAddress: "01:02:03:04:05:06", Password: "password", Network: "skynet"}
node, _ := CreateNode(createnode, "skynet")
return node
}

View File

@@ -1,172 +0,0 @@
package controller
import (
"testing"
"time"
"github.com/gravitl/netmaker/database"
"github.com/gravitl/netmaker/models"
"github.com/stretchr/testify/assert"
)
func TestGetPeerList(t *testing.T) {
database.InitializeDatabase()
database.InitializeDatabase()
//deleteNet(t)
//createNet()
_ = createTestNode(t)
//createnode := models.Node{PublicKey: "RM5qhLAE20PG9BbfBCger+Ac9D2NDOwCtY1rbYDLf34=", Endpoint: "10.0.0.2", MacAddress: "02:02:03:04:05:06", Password: "password", Network: "skynet"}
//_, _ = CreateNode(createnode, "skynet")
t.Run("PeerExist", func(t *testing.T) {
peers, err := GetPeersList("skynet")
assert.Nil(t, err)
assert.NotEqual(t, []models.PeersResponse(nil), peers)
t.Log(peers)
})
t.Run("NoNodes", func(t *testing.T) {
// _ = DeleteNode("01:02:03:04:05:06", "skynet")
peers, err := GetPeersList("skynet")
assert.Nil(t, err)
assert.Equal(t, []models.PeersResponse(nil), peers)
t.Log(peers)
})
}
type NodeValidationTC struct {
testname string
node models.Node
errorMessage string
}
type NodeValidationUpdateTC struct {
testname string
node models.Node
errorMessage string
}
func TestDeleteNode(t *testing.T) {
database.InitializeDatabase()
//deleteNet(t)
//createNet()
//node := createTestNode(t)
t.Run("NodeExists", func(t *testing.T) {
//err := DeleteNode(node.MacAddress, node.Network)
//assert.Nil(t, err)
})
t.Run("NonExistantNode", func(t *testing.T) {
//err := DeleteNode(node.MacAddress, node.Network)
//assert.Nil(t, err)
})
}
func TestGetNode(t *testing.T) {
database.InitializeDatabase()
//deleteNet(t)
//createNet()
node := createTestNode(t)
t.Run("NodeExists", func(t *testing.T) {
response, err := GetNode(node.MacAddress, node.Network)
assert.Nil(t, err)
assert.Equal(t, "10.0.0.1", response.Endpoint)
assert.Equal(t, "DM5qhLAE20PG9BbfBCger+Ac9D2NDOwCtY1rbYDLf34=", response.PublicKey)
assert.Equal(t, "01:02:03:04:05:06", response.MacAddress)
assert.Equal(t, int32(51821), response.ListenPort)
assert.NotNil(t, response.Name)
assert.Equal(t, "skynet", response.Network)
assert.Equal(t, "nm-skynet", response.Interface)
})
t.Run("BadMac", func(t *testing.T) {
response, err := GetNode("01:02:03:04:05:07", node.Network)
assert.NotNil(t, err)
assert.Equal(t, models.Node{}, response)
assert.Equal(t, "mongo: no documents in result", err.Error())
})
t.Run("BadNetwork", func(t *testing.T) {
response, err := GetNode(node.MacAddress, "badnet")
assert.NotNil(t, err)
assert.Equal(t, models.Node{}, response)
assert.Equal(t, "mongo: no documents in result", err.Error())
})
t.Run("NoNode", func(t *testing.T) {
//_ = DeleteNode("01:02:03:04:05:06", "skynet")
response, err := GetNode(node.MacAddress, node.Network)
assert.NotNil(t, err)
assert.Equal(t, models.Node{}, response)
//assert.Equal(t, "mongo: no documents in result", err.Error())
})
}
func TestCreateNode(t *testing.T) {
database.InitializeDatabase()
//deleteNet(t)
//createNet()
createnode := models.Node{PublicKey: "DM5qhLAE20PG9BbfBCger+Ac9D2NDOwCtY1rbYDLf34=", Endpoint: "10.0.0.1", MacAddress: "01:02:03:04:05:06", Password: "password", Network: "skynet"}
//err := ValidateNodeCreate("skynet", createnode)
//assert.Nil(t, err)
node, err := CreateNode(createnode, "skynet")
assert.Nil(t, err)
assert.Equal(t, "10.0.0.1", node.Endpoint)
assert.Equal(t, "DM5qhLAE20PG9BbfBCger+Ac9D2NDOwCtY1rbYDLf34=", node.PublicKey)
assert.Equal(t, "01:02:03:04:05:06", node.MacAddress)
assert.Equal(t, int32(51821), node.ListenPort)
assert.NotNil(t, node.Name)
assert.Equal(t, "skynet", node.Network)
assert.Equal(t, "nm-skynet", node.Interface)
}
func TestSetNetworkNodesLastModified(t *testing.T) {
database.InitializeDatabase()
//deleteNet(t)
//createNet()
t.Run("InvalidNetwork", func(t *testing.T) {
err := SetNetworkNodesLastModified("badnet")
assert.NotNil(t, err)
assert.Equal(t, "mongo: no documents in result", err.Error())
})
t.Run("NetworkExists", func(t *testing.T) {
err := SetNetworkNodesLastModified("skynet")
assert.Nil(t, err)
})
}
func TestTimestampNode(t *testing.T) {
database.InitializeDatabase()
//deleteNet(t)
//createNet()
node := createTestNode(t)
time.Sleep(time.Second * 1)
before, err := GetNode(node.MacAddress, node.Network)
assert.Nil(t, err)
t.Run("UpdateCheckIn", func(t *testing.T) {
err = TimestampNode(node, true, false, false)
assert.Nil(t, err)
after, err := GetNode(node.MacAddress, node.Network)
assert.Nil(t, err)
assert.Greater(t, after.LastCheckIn, before.LastCheckIn)
})
t.Run("UpdatePeers", func(t *testing.T) {
err = TimestampNode(node, false, true, false)
assert.Nil(t, err)
after, err := GetNode(node.MacAddress, node.Network)
assert.Nil(t, err)
assert.Greater(t, after.LastPeerUpdate, before.LastPeerUpdate)
})
t.Run("UpdateLastModified", func(t *testing.T) {
err = TimestampNode(node, false, false, true)
assert.Nil(t, err)
after, err := GetNode(node.MacAddress, node.Network)
assert.Nil(t, err)
assert.Greater(t, after.LastModified, before.LastModified)
})
t.Run("InvalidNode", func(t *testing.T) {
node.MacAddress = "01:02:03:04:05:08"
err = TimestampNode(node, true, true, true)
assert.NotNil(t, err)
//assert.Equal(t, "mongo: no documents in result", err.Error())
})
}
func createTestNode(t *testing.T) models.Node {
createnode := models.Node{PublicKey: "DM5qhLAE20PG9BbfBCger+Ac9D2NDOwCtY1rbYDLf34=", Endpoint: "10.0.0.1", MacAddress: "01:02:03:04:05:06", Password: "password", Network: "skynet"}
node, err := CreateNode(createnode, "skynet")
assert.Nil(t, err)
t.Log(err)
return node
}