zishuo/netmaker
1
0
Fork 0
mirror of https://github.com/gravitl/netmaker.git synced 2025-10-05 16:57:51 +08:00
Code Issues Packages Projects Releases Wiki Activity

Revert: changing mechanics of loop (for ease of pr review)

Browse Source 
cherry-pick the ineffective `err` assignment to make our following error check not useless
This commit is contained in:
kayos@tcp.direct
2022-12-06 20:26:46 -08:00
parent e878e4820a
commit 4c4cd6eb4d
1 changed files with 1 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
netclient/ncutils/netclientutils.go
View File

@@ -162,29 +162,18 @@ func GetPublicIP(api string) (string, error) {
iplist = append([]string{api}, iplist...) iplist = append([]string{api}, iplist...)
} }
var bodies []*http.Response
defer func() {
for _, res := range bodies {
if res != nil {
_ = res.Body.Close()
}
}
}()
endpoint := "" endpoint := ""
var err error var err error
for _, ipserver := range iplist { for _, ipserver := range iplist {
client := &http.Client{ client := &http.Client{
Timeout: time.Second * 10, Timeout: time.Second * 10,
} }
var resp *http.Response var resp *http.Response
resp, err = client.Get(ipserver) resp, err = client.Get(ipserver)
if err != nil { if err != nil {
continue continue
} }
defer resp.Body.Close()
bodies = append(bodies, resp)
if resp.StatusCode == http.StatusOK { if resp.StatusCode == http.StatusOK {
var bodyBytes []byte var bodyBytes []byte
bodyBytes, err = io.ReadAll(resp.Body) bodyBytes, err = io.ReadAll(resp.Body)