zishuo/netmaker
1
0
Fork 0
mirror of https://github.com/gravitl/netmaker.git synced 2025-10-05 08:47:35 +08:00
Code Issues Packages Projects Releases Wiki Activity

fixed UpdateNetwork/InvalidAddress

Browse Source
This commit is contained in:
Matthew R Kasun
2021-04-17 15:12:03 -04:00
parent c62dc50d46
commit 1c7dbd42c9
3 changed files with 33 additions and 74 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
controllers/networkHttpController.go
View File

@@ -308,12 +308,6 @@ func updateNetwork(w http.ResponseWriter, r *http.Request) {
networkChange.NetID = network.NetID
}
//err = validateNetwork("update", networkChange)
if err != nil {
returnErrorResponse(w, r, formatError(err, "internal"))
return
}
err = validateNetworkUpdate(networkChange)
if err != nil {
returnErrorResponse(w, r, formatError(err, "badrequest"))
@@ -326,7 +320,7 @@ func updateNetwork(w http.ResponseWriter, r *http.Request) {
returnErrorResponse(w, r, formatError(errors.New("NetID is not editable"), "badrequest"))
return
}
//MRK: I think this code block is redundant. valdiateNetworkUpdate(networkChange) covers this
if networkChange.AddressRange != "" {
network.AddressRange = networkChange.AddressRange