From 0da99d8437237c9c9b1feaa812c3cd781b2978f9 Mon Sep 17 00:00:00 2001 From: Abhishek Kondur Date: Thu, 19 Jan 2023 15:19:05 +0530 Subject: [PATCH] skip pending delete nodes --- logic/hosts.go | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/logic/hosts.go b/logic/hosts.go index a03ec962..ebc6882a 100644 --- a/logic/hosts.go +++ b/logic/hosts.go @@ -161,7 +161,7 @@ func RemoveHostByID(hostID string) error { func UpdateHostNetwork(h *models.Host, network string, add bool) (*models.Node, error) { for _, nodeID := range h.Nodes { node, err := GetNodeByID(nodeID) - if err != nil { + if err != nil || node.PendingDelete { continue } if node.Network == network { @@ -175,9 +175,7 @@ func UpdateHostNetwork(h *models.Host, network string, add bool) (*models.Node, } if !add { return nil, errors.New("host not part of the network " + network) - } - - if add { + } else { newNode := models.Node{} newNode.Server = servercfg.GetServer() newNode.Network = network @@ -186,8 +184,6 @@ func UpdateHostNetwork(h *models.Host, network string, add bool) (*models.Node, } return &newNode, nil } - - return nil, errors.New("failed to update host networks") } // AssociateNodeToHost - associates and creates a node with a given host