Change to single variable in ClientConfig (no nested GlobalSettings).

This commit is contained in:
cameronts
2022-07-28 12:50:53 -07:00
parent 1cb42e8f8b
commit 05283eff14
3 changed files with 4 additions and 9 deletions

View File

@@ -26,16 +26,11 @@ type ClientConfig struct {
Server models.ServerConfig `yaml:"server"`
Node models.Node `yaml:"node"`
NetworkSettings models.Network `yaml:"networksettings"`
GlobalSettings GlobalSettings `yaml:"globalSettings"`
Network string `yaml:"network"`
Daemon string `yaml:"daemon"`
OperatingSystem string `yaml:"operatingsystem"`
AccessKey string `yaml:"accesskey"`
}
// GlobalSettings - settings that apply for the netclient across networks
type GlobalSettings struct {
PublicIPService string `yaml:"publicIPService"`
PublicIPService string `yaml:"publicipservice"`
}
// RegisterRequest - struct for registation with netmaker server
@@ -237,7 +232,7 @@ func GetCLIConfig(c *cli.Context) (ClientConfig, string, error) {
cfg.Server.CoreDNSAddr = c.String("corednsaddr")
cfg.Server.API = c.String("apiserver")
}
cfg.GlobalSettings.PublicIPService = c.String("publicipservice")
cfg.PublicIPService = c.String("publicipservice")
cfg.Node.Name = c.String("name")
cfg.Node.Interface = c.String("interface")
cfg.Node.Password = c.String("password")

View File

@@ -85,7 +85,7 @@ func JoinNetwork(cfg *config.ClientConfig, privateKey string) error {
if cfg.Node.IsLocal == "yes" && cfg.Node.LocalAddress != "" {
cfg.Node.Endpoint = cfg.Node.LocalAddress
} else {
cfg.Node.Endpoint, err = ncutils.GetPublicIP(cfg.GlobalSettings.PublicIPService)
cfg.Node.Endpoint, err = ncutils.GetPublicIP(cfg.PublicIPService)
}
if err != nil || cfg.Node.Endpoint == "" {
logger.Log(0, "network:", cfg.Network, "error setting cfg.Node.Endpoint.")

View File

@@ -44,7 +44,7 @@ func checkin() {
nodeCfg.Network = network
nodeCfg.ReadConfig()
if nodeCfg.Node.IsStatic != "yes" {
extIP, err := ncutils.GetPublicIP(nodeCfg.GlobalSettings.PublicIPService)
extIP, err := ncutils.GetPublicIP(nodeCfg.PublicIPService)
if err != nil {
logger.Log(1, "error encountered checking public ip addresses: ", err.Error())
}