"encoders/protobuf/protobuf_enc.go:19:2: package github.com/golang/protobuf/proto is deprecated: Use the "google.golang.org/protobuf/proto" package instead."
I have replaced and regenerated the testdata protobuf code.
I have tested that if an app was built with the library before
the change and would receive a message generated with the updated
import it would work fine.
However an app using the updated library would need to replace
```
reflect.DeepEqual(m1, m2)
```
with
```
reflect.DeepEqual(m1.ProtoReflect(), m2.ProtoReflect())
```
The protobuf Message has different versions now.
Not sure if this going to break things or not, but the
github.com/golang/protobuf/proto is clearly marked as deprecated.
Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
* refactored to remove exported gnatsd dependency.
* updated with prefix and coverage tests to accurately get coverage numbers for encoders packages.
* resolving coverage change issues.
* eliminated extra run of test for coverage.
* include -race in coverage
* updated to remove variable. thx @wallyqs
Added gosimple + update to staticcheck
Based on @y0ssar1an PRs.
- Update go versions to .4
- Get gosimple package
- Updated staticcheck's URL
- Use staticcheck.ignore file for exceptions
- Moved build and staticcheck/gosimple checks in `before_script`
section to fail fast
- Fixed reports from gosimple and staticcheck
* Fixed RACE condition between flusher() and close() caused by kickFlusher invoked from close() outside of connection's lock.
* Specify "-p=1" in travis.yml so that package tests are not running in parallel, which otherwise may cause test failures.
* Systematic use of 'defer' for server shutdown and connection close, even when the server/connection is explicitly shutdown/close in the test (these calls are idemptotent anyway), so that if a failure occurs between the starting/creation of the server/connection, and the explicit shutdown/close, the appropriate cleanup function will be invoked.
* Adjusted some of the timings
* Made the test checking for the timing of the Closed state a warning instead of a fatal error, since even locally I would sometimes get more than what the test program is expecting (which could be even longer on Travis).
