From dd77530fdb61fc15fc9dfb00dc3067a7f3f95a95 Mon Sep 17 00:00:00 2001 From: Martin Angers Date: Sat, 24 Mar 2018 12:12:09 -0400 Subject: [PATCH] update examples to use the preferred NewDocumentFromReader approach --- README.md | 20 ++++++++++++++++---- example_test.go | 13 ++++++++++++- 2 files changed, 28 insertions(+), 5 deletions(-) diff --git a/README.md b/README.md index fba004d..a10693d 100644 --- a/README.md +++ b/README.md @@ -95,15 +95,27 @@ package main import ( "fmt" "log" + "net/http" "github.com/PuerkitoBio/goquery" ) func ExampleScrape() { - doc, err := goquery.NewDocument("http://metalsucks.net") - if err != nil { - log.Fatal(err) - } + // Request the HTML page. + res, err := http.Get("http://metalsucks.net") + if err != nil { + log.Fatal(err) + } + defer res.Body.Close() + if res.StatusCode != 200 { + log.Fatalf("status code error: %d %s", res.StatusCode, res.Status) + } + + // Load the HTML document + doc, err := goquery.NewDocumentFromReader(res.Body) + if err != nil { + log.Fatal(err) + } // Find the review items doc.Find(".sidebar-reviews article .content-block").Each(func(i int, s *goquery.Selection) { diff --git a/example_test.go b/example_test.go index 17b2354..ff1b0c7 100644 --- a/example_test.go +++ b/example_test.go @@ -3,14 +3,25 @@ package goquery_test import ( "fmt" "log" + "net/http" "github.com/PuerkitoBio/goquery" ) // This example scrapes the reviews shown on the home page of metalsucks.net. func Example() { + // Request the HTML page. + res, err := http.Get("http://metalsucks.net") + if err != nil { + log.Fatal(err) + } + defer res.Body.Close() + if res.StatusCode != 200 { + log.Fatalf("status code error: %d %s", res.StatusCode, res.Status) + } + // Load the HTML document - doc, err := goquery.NewDocument("http://metalsucks.net") + doc, err := goquery.NewDocumentFromReader(res.Body) if err != nil { log.Fatal(err) }