zishuo/goquery
1
0
Fork 0
mirror of https://github.com/PuerkitoBio/goquery synced 2025-10-22 16:09:21 +08:00
Code Issues Packages Projects Releases Wiki Activity

comment and explain the appendWithoutDuplicates logic

Browse Source
This commit is contained in:
Martin Angers
2016-08-27 22:29:53 -04:00
parent 7bd630023a
commit 6841d28c6f
1 changed files with 4 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
utilities.go
View File

@@ -117,6 +117,8 @@ func indexInSlice(slice []*html.Node, node *html.Node) int {
func appendWithoutDuplicates(target []*html.Node, nodes []*html.Node, targetSet map[*html.Node]bool) []*html.Node { func appendWithoutDuplicates(target []*html.Node, nodes []*html.Node, targetSet map[*html.Node]bool) []*html.Node {
const minNodesForSet = 1000 const minNodesForSet = 1000
// if there are not that many nodes, don't use the map, faster to just use nested loops
// (unless a non-nil targetSet is passed, in which case the caller knows better).
if targetSet == nil && len(target)+len(nodes) < minNodesForSet { if targetSet == nil && len(target)+len(nodes) < minNodesForSet {
for _, n := range nodes { for _, n := range nodes {
if !isInSlice(target, n) { if !isInSlice(target, n) {
@@ -126,6 +128,8 @@ func appendWithoutDuplicates(target []*html.Node, nodes []*html.Node, targetSet
return target return target
} }
// if a targetSet is passed, then assume it is reliable, otherwise create one
// and initialize it with the current target contents.
if targetSet == nil { if targetSet == nil {
targetSet = make(map[*html.Node]bool, len(target)) targetSet = make(map[*html.Node]bool, len(target))
for _, n := range target { for _, n := range target {