mirror of
https://github.com/burrowers/garble.git
synced 2025-12-24 12:58:05 +08:00
66b61406c1
When updating Garble to support Go 1.22.0, CI on MacOS spotted that the syscall package was failing to build given that it uses assembly code which is only allowed in some std packages. That allowlist is based on import paths, and we were obfuscating the syscall package's import path, so that was breaking GOOS=darwin. As a fix, I added syscall to runtimeAndDeps to not obfuscate it. That wasn't a great fix; it's not part of runtime and its dependencies, and there's no reason we should avoid obfuscating the package contents. Not obfuscating the contents in fact broke x/sys/unix, as it contains a copy of syscall.Rlimit which it type converted with. Undo that fix and reinstate the gogarble.txtar syscall test. Implement the fix where we only leave syscall's import path alone. Add a regression test, and add a note about adding x/net and x/sys to check-third-party.sh so that we can catch these bugs earlier. Fixes #830.
64 lines
1.8 KiB
Bash
Executable File
64 lines
1.8 KiB
Bash
Executable File
#!/bin/bash
|
|
|
|
# We can rewrite this bash script in Go if a dependency on bash and coreutils
|
|
# is a problem during development.
|
|
|
|
goroot=$(go env GOROOT)
|
|
go_version=$(go env GOVERSION) # not "go version", to exclude GOOS/GOARCH
|
|
|
|
runtime_and_deps=$(go list -deps runtime)
|
|
|
|
# All packages that the runtime linknames to, except runtime and its dependencies.
|
|
# This resulting list is what we need to "go list" when obfuscating the runtime,
|
|
# as they are the packages that we may be missing.
|
|
runtime_linknamed=$(comm -23 <(
|
|
sed -rn 's@//go:linkname .* ([^.]*)\.[^.]*@\1@p' "${goroot}"/src/runtime/*.go | grep -vE '^main|^runtime\.|_test$' | sort -u
|
|
) <(
|
|
# Note that we assume this is constant across platforms.
|
|
go list -deps runtime | sort -u
|
|
))
|
|
|
|
compiler_intrinsics_table="$(sed -rn 's@.*\b(addF|alias)\("([^"]*)", "([^"]*)",.*@\2 \3@p' "${goroot}"/src/cmd/compile/internal/ssagen/ssa.go | sort -u)"
|
|
compiler_intrinsics_paths="$(while read path name; do
|
|
echo ${path}
|
|
done <<<"${compiler_intrinsics_table}" | sort -u)"
|
|
|
|
gofmt >go_std_tables.go <<EOF
|
|
// Code generated by scripts/gen-go-std-tables.sh; DO NOT EDIT.
|
|
|
|
// Generated from Go version ${go_version}.
|
|
|
|
package main
|
|
|
|
var runtimeAndDeps = map[string]bool{
|
|
$(for path in ${runtime_and_deps}; do
|
|
echo "\"${path}\": true,"
|
|
done)
|
|
}
|
|
|
|
var runtimeLinknamed = []string{
|
|
$(for path in ${runtime_linknamed}; do
|
|
echo "\"${path}\"",
|
|
done)
|
|
// The net package linknames to the runtime, not the other way around.
|
|
// TODO: support this automatically via our script.
|
|
"net",
|
|
}
|
|
|
|
var compilerIntrinsicsPkgs = map[string]bool{
|
|
$(for path in ${compiler_intrinsics_paths}; do
|
|
echo "\"${path}\": true,"
|
|
done)
|
|
}
|
|
|
|
var compilerIntrinsicsFuncs = map[string]bool{
|
|
$(while read path name; do
|
|
echo "\"${path}.${name}\": true,"
|
|
done <<<"${compiler_intrinsics_table}")
|
|
}
|
|
|
|
var reflectSkipPkg = map[string]bool{
|
|
"fmt": true,
|
|
}
|
|
EOF
|