zishuo/frigate
1
0
Fork 0
mirror of https://github.com/blakeblackshear/frigate.git synced 2025-09-26 19:41:29 +08:00
Code Issues Packages Projects Releases Wiki Activity

Remove internal docker container IP from WebRTC candidates (#16618)

Browse Source
This commit is contained in:
Felipe Santos
2025-02-17 01:24:13 -03:00
committed by GitHub
parent 92553fa666
commit 349abc8d1b
1 changed files with 14 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

25
docker/main/rootfs/usr/local/go2rtc/create_config.py
View File

@@ -66,29 +66,32 @@ elif go2rtc_config["log"].get("format") is None:
go2rtc_config["log"]["format"] = "text" go2rtc_config["log"]["format"] = "text"
# ensure there is a default webrtc config # ensure there is a default webrtc config
if not go2rtc_config.get("webrtc"): if go2rtc_config.get("webrtc") is None:
go2rtc_config["webrtc"] = {} go2rtc_config["webrtc"] = {}
# go2rtc should listen on 8555 tcp & udp by default # go2rtc should listen on 8555 tcp & udp by default
if not go2rtc_config["webrtc"].get("listen"): if go2rtc_config["webrtc"].get("listen") is None:
go2rtc_config["webrtc"]["listen"] = ":8555" go2rtc_config["webrtc"]["listen"] = ":8555"
if not go2rtc_config["webrtc"].get("candidates", []): if go2rtc_config["webrtc"].get("candidates") is None:
default_candidates = [] default_candidates = []
# use internal candidate if it was discovered when running through the add-on # use internal candidate if it was discovered when running through the add-on
internal_candidate = os.environ.get( internal_candidate = os.environ.get("FRIGATE_GO2RTC_WEBRTC_CANDIDATE_INTERNAL")
"FRIGATE_GO2RTC_WEBRTC_CANDIDATE_INTERNAL", None
)
if internal_candidate is not None: if internal_candidate is not None:
default_candidates.append(internal_candidate) default_candidates.append(internal_candidate)
# should set default stun server so webrtc can work # should set default stun server so webrtc can work
default_candidates.append("stun:8555") default_candidates.append("stun:8555")
go2rtc_config["webrtc"] = {"candidates": default_candidates} go2rtc_config["webrtc"]["candidates"] = default_candidates
else:
print( # This prevents WebRTC from attempting to establish a connection to the internal
"[INFO] Not injecting WebRTC candidates into go2rtc config as it has been set manually", # docker IPs which are not accessible from outside the container itself and just
) # wastes time during negotiation. Note that this is only necessary because
# Frigate container doesn't run in host network mode.
if go2rtc_config["webrtc"].get("filter") is None:
go2rtc_config["webrtc"]["filter"] = {"candidates": []}
elif go2rtc_config["webrtc"]["filter"].get("candidates") is None:
go2rtc_config["webrtc"]["filter"]["candidates"] = []
# sets default RTSP response to be equivalent to ?video=h264,h265&audio=aac # sets default RTSP response to be equivalent to ?video=h264,h265&audio=aac
# this means user does not need to specify audio codec when using restream # this means user does not need to specify audio codec when using restream