zishuo/chaisql
1
0
Fork 0
mirror of https://github.com/chaisql/chai.git synced 2025-10-16 12:40:49 +08:00
Code Issues Packages Projects Releases Wiki Activity

Handle integer conversion errors (#425)

Browse Source 
When converting a double larger or equal to math.MaxInt64 to an integer, it previously overflowed silently. It now returns an explicit error.

This fixes along the way, the math.abs(-9223372036854775808) issue.
This commit is contained in:
Jean Hadrien Chabran
2021-07-25 18:25:02 +02:00
committed by GitHub
parent daf4f79e9f
commit 01c87d1bf7
4 changed files with 54 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
internal/testutil/expr.go
View File

@@ -152,7 +152,7 @@ func ExprRunner(t *testing.T, testfile string) {
require.NoError(t, err)
// eval it to get a proper Value
want, err := e.Eval(emptyEnv)
want, err := e.Eval(environment.New(nil))
require.NoError(t, err)
// parse the given expr
@@ -160,7 +160,7 @@ func ExprRunner(t *testing.T, testfile string) {
require.NoError(t, err)
// eval it to get a proper Value
got, err := e.Eval(emptyEnv)
got, err := e.Eval(environment.New(nil))
require.NoError(t, err)
// finally, compare those two
@@ -170,12 +170,14 @@ func ExprRunner(t *testing.T, testfile string) {
t.Run("NOK "+stmt.Expr, func(t *testing.T) {
// parse the given epxr
e, err := parser.NewParser(strings.NewReader(stmt.Expr)).ParseExpr()
require.NoError(t, err)
// eval it, it should return an error
_, err = e.Eval(emptyEnv)
require.NotNilf(t, err, "expected expr `%s` to return an error, got nil", stmt.Expr)
require.Regexp(t, regexp.MustCompile(regexp.QuoteMeta(stmt.Res)), err.Error())
if err != nil {
require.Regexp(t, regexp.MustCompile(regexp.QuoteMeta(stmt.Res)), err.Error())
} else {
// eval it, it should return an error
_, err = e.Eval(environment.New(nil))
require.NotNilf(t, err, "expected expr `%s` to return an error, got nil", stmt.Expr)
require.Regexp(t, regexp.MustCompile(regexp.QuoteMeta(stmt.Res)), err.Error())
}
})
}
}